Skip to content

Add option to mark integration tests CTAO use case and requirements. #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Feb 28, 2025

Allow to mark integration tests in their use case config with a corresponding CTAO use case or requirement ID, see pytest-requirements package description.

@GernotMaier GernotMaier self-assigned this Feb 28, 2025

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

@GernotMaier GernotMaier marked this pull request as ready for review February 28, 2025 13:32
@GernotMaier GernotMaier marked this pull request as draft February 28, 2025 13:32
@GernotMaier GernotMaier marked this pull request as ready for review March 1, 2025 15:30

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (94.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

@maxnoe
Copy link
Collaborator

maxnoe commented Mar 4, 2025

A minor note, as I don't know if this is relevant to you, in general, the use case to test mapping is many-to-many.

So you might want to make the id fields lists instead of a single string and add a loop to add the markers.

@GernotMaier
Copy link
Contributor Author

@maxnoe - thanks for this. This will be easy to extend - I however can't think a case right now where this would be the case. I suggest to review this PR and add the extension to list when needed.



@pytest.fixture(scope="session", params=test_configs)
def test_config(request):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider adding a short docstring.

@GernotMaier GernotMaier merged commit 4746f71 into main Mar 4, 2025
14 checks passed
@GernotMaier GernotMaier deleted the ctao-use-cases branch March 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants