Improvements to production docker images: arm compatibility; run integration tests #1420
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
| - {build_opt: 'prod6-baseline', extra_def: ''} | ||
| avx_instruction: ['no_opt'] | ||
| container: | ||
| image: ghcr.io/gammasim/simtools-prod-opt-${{ matrix.version.simtel_version }}-corsika-${{ matrix.version.corsika_version }}-bernlohr-${{ matrix.version.bernlohr_version }}-${{ matrix.production.build_opt }}-${{ matrix.hadronic_model }}-${{ matrix.avx_instruction }} |
There was a problem hiding this comment.
What's the opt in prod-opt here?
Reading further, I understand it comes from Docker image name. Are they still separate and the opt is needed?
There was a problem hiding this comment.
Removed the opt. Good point.
|
|
||
| - name: Set sim_telarray path | ||
| run: | | ||
| echo "PATH=\$PATH:/usr/bin:/usr/local/bin:$SIMTOOLS_SIMTEL_PATH" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Do you really need to explicitly set /usr/bin:/usr/local/bin? There's no harm in it of course, but if it's not needed I would remove it (who knows, maybe in a future OS it will change).
There was a problem hiding this comment.
Yes, needed - running the workflow without it will give you:
OCI runtime exec failed: exec failed: unable to start container process: exec: "sh": executable file not found in $PATH: unknown
docker/Dockerfile-prod-opt
Outdated
| COPY --from=build_image /workdir/sim_telarray/ /workdir/sim_telarray/ | ||
|
|
||
| RUN microdnf update -y && microdnf install -y \ | ||
| bc findutils gcc-c++ git gsl-devel gcc-fortran libgfortran \ | ||
| procps python3.11-pip zstd && \ | ||
| procps python3.12-devel zstd && \ |
There was a problem hiding this comment.
Should the python version be an argument that updates when we updated the supported versions?
There was a problem hiding this comment.
Good point, added.
This comment has been minimized.
This comment has been minimized.
GernotMaier
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks @orelgueta for the review. I tried to address them, let me know if there is anything else. |
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w |
|
Thanks a lot @orelgueta - and no worries, no other PR depends directly on this work. |
Two improvements regarding the production images:
avx2flag for non-optimized images to allow to run them on arm-based CPUs (still need to usepodman run --arch amd64 ...to execute)Note that this is in some sense a duplication of what has been / will be added in the SimPipe gitlab repository. However, for it is easier to develop these steps here.
Minor changes:
noOpttono-opt.imagefile in one single line.