Fix unit test to run with astropy 7.1 (and earlier versions) #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates unit tests to handle both old and new Astropy error messages and logs the change in the project changelog.
- Adjust
pytest.raisesmatch to a regex that covers both Astropy 7.1 and earlier messages - Add a one-line entry to
docs/changesfor this fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit_tests/data_model/test_format_checkers.py | Relax error‐message matching to r"^None.*Unit$" for backward compatibility |
| docs/changes/1575.maintence.md | Add changelog entry |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w |
EshitaJoshi
approved these changes
May 21, 2025
|
Thanks @EshitaJoshi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astropy 7.1 changes the error message
to
This resulted in failure of
tests/unit_tests/data_model/test_format_checkers.py. Change the string matching now to test for a error message starting withNoneand ending withUnitto cover both old and new versions.I have tested it by:
Closes #1574