Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better registry handling ✨ #712

Merged
merged 19 commits into from
Jan 17, 2025
Merged

feat: better registry handling ✨ #712

merged 19 commits into from
Jan 17, 2025

Conversation

liquidiert
Copy link
Collaborator

@liquidiert liquidiert commented Oct 14, 2024 •
edited
Loading

  • add registry url cli option for easy registry change
  • fix service annotations
  • fix replacement of kwargs with empty dict by filtering only the empty values

closes #703
closes #670
closes #738

@liquidiert
feat: better registry handling ✨
1e1f430 
  - add registry url cli option for easy registry change
  - fix service annotations
  - fix replacement of kwargs with empty dict by filtering only the empty values
@liquidiert
fix: missing comma in install api
6d00f86
@liquidiert
fix: annotation split
ec42740
@liquidiert liquidiert requested a review from Schille October 18, 2024 10:41
@liquidiert liquidiert requested a review from Schille October 21, 2024 11:43
@Schille
Copy link
Collaborator

Schille commented Oct 29, 2024 •
edited
Loading

With a custom registry link, you must also pass this as env for Stowaway. Otherwise, you'll end up with this component pulled from the default registry:

gefyra/operator/gefyra/configuration.py

Lines 7 to 10 in 9fcbf7e

self.STOWAWAY_IMAGE = config(
"GEFYRA_STOWAWAY_IMAGE", default="quay.io/gefyra/stowaway"
)
self.STOWAWAY_IMAGE_PULLPOLICY = config(

Look for the workload definition of Stowaway in the Operator code to set this env (it's currently not specified and hence uses the default).

@liquidiert
Merge branch 'main' into feature/703_better-registry-handling
18d2eb0
@liquidiert
feat: better registry handling
58e5a1a 
  - rename registry param
  - add env vars to operator
  - add stowaway pvc size handling
@liquidiert
chore: formatting
f2ed0c0
@crkurz
Copy link

crkurz commented Nov 5, 2024

@Schille ,
it appears this will also solve packet drops due to MTU size when used with CISCO VPN, which is terrific! Thank you!

Nit: for tracking do we need a ticket for MTU size problem and should that ticket be linked to this PR?

@crkurz
Copy link

crkurz commented Nov 5, 2024

@Schille ,
fyi, I have filed GEFYRA-738 for MTU issue. This might need to be linked to this PR.

@liquidiert liquidiert requested review from Schille and removed request for Schille January 14, 2025 13:51
@liquidiert liquidiert requested a review from Schille January 15, 2025 09:53
@liquidiert liquidiert removed the request for review from Schille January 16, 2025 12:50
@liquidiert liquidiert requested a review from Schille January 16, 2025 17:13
@Schille Schille requested a review from SteinRobert January 17, 2025 09:24
Schille
Schille approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@Schille Schille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This became a relatively big change set. It looks okayish to me. Let's see if @SteinRobert approves, too.

@SteinRobert SteinRobert merged commit 553cfe1 into main Jan 17, 2025
20 checks passed
@Schille Schille deleted the feature/703_better-registry-handling branch February 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schille Schille Schille approved these changes

@SteinRobert SteinRobert SteinRobert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@liquidiert @Schille @crkurz @SteinRobert