This repository was archived by the owner on Sep 3, 2018. It is now read-only.
Pull latest upstream changes and remove redundant require("child_process") #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made the request headers case insensitive for setting and getting by creating a mapping hash to map the insensitive names with the ones used in setting. I've also fixed setRequestHeader to append values to existing ones as per the spec. Because of this I needed to set the defaults on send if they haven't been set previously (user-agent obviously can't because it's in the restricted list).
specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/
2) the status property must return 0 if the error flag is set
When the URL is just a relative path, as in /blah/bleh, at least in v0.12.7, url.protocol is not set at all, thus, it’s null.
Consider null protocol as missing protocol, not an unsupported one.
Add events `error` and `abort`
Update license attribute
Expose xhr.withCredentials with correct default
…HttpRequest into AWinterman-throw-errors
Fixes request headers to conform to spec more closely.
gena
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull latest upstream changes and remove redundant require("child_process")