Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symbolic link from GCHP root folder to the test folder #327

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jun 28, 2023

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is a companion PR to geoschem/geos-chem#1794. This resets the test folder to the new path src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/test to be consistent with the changes made in the geoschem/geos-chem repo.

Expected changes

This is a zero-diff update, as it only modifies a symbolic link. No scientific changes are added.

Reference(s)

N/A

Related Github Issue(s)

Sorry, something went wrong.

Change symbolic link:
 src/GCHP_GridComp/GEOSChem_GridComp/geoschem/test/GCHP

to
 src/GCHP_GridComp/GEOSChem_GridComp/geoschem/test

since this new test folder now contains the following directories:

 difference/
 integration/
 parallel/
 shared/

To get to the GCHP integration tests, now use:

 cd gchp/test/integration/GCHP

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations structural labels Jun 28, 2023
@yantosca yantosca added this to the 14.2.1 milestone Jun 28, 2023
@yantosca yantosca requested a review from lizziel June 28, 2023 20:37
@yantosca yantosca self-assigned this Jun 28, 2023
CHANGELOG.md
- Added sentence about the 'test' folder being repointed to
  'src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/test'.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca merged commit 76d9382 into dev/14.2.1 Jul 5, 2023
@yantosca yantosca deleted the feature/int-test-rundir-updates branch July 5, 2023 17:21
@yantosca
Copy link
Contributor Author

yantosca commented Jul 5, 2023

Merged upon successful integration tests (and confirmation of zero-diff results) of geoschem/geos-chem#1794.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants