Add Cloud-J as submodule to GCHP #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Default is currently off (will use Fast-JX) Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…TJX=y Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
> Remove unused common variables JXL_, JXL1_, and JXL2_ > Make number of CTM levels set by the calling program during initialization > Merge pull request #4 from jimmielin/hplin/fix_decl_ifort > Updates for using MAPL in Cloud-J Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
changed the title
yantosca
added
category: Feature Request
# Conflicts: # CHANGELOG.md Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/cloud-j
branch
from
8dade0d to
1328cd0
Compare
msulprizio
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This update adds the Cloud-J photolysis library as a submodule with GCHP. It is stored alongside GEOS-Chem in
src/GCHP_GridComp/Chem_GridComp. This PR should be merged with geoschem/geos-chem#1522.Expected changes
See geoschem/geos-chem#1522 for changes expected in GEOS-Chem when using Cloud-J to compute J-values.
Reference(s)
Prather, M. J.: Photolysis rates in correlated overlapping cloud fields: Cloud-J 7.3c, Geosci. Model Dev., 8, 2587–2595, https://doi.org/10.5194/gmd-8-2587-2015, 2015.
Related Github Issue(s)
geoschem/geos-chem#1522