New submodule: HETP aerosol thermodynamics #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This was referenced Apr 18, 2024
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This commit move the submodules used within GEOS-Chem to within the GEOSChem_GridComp directory so they are alongside GEOS-Chem. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…ables Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
yantosca
added
category: Feature Request
yantosca
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks @lizziel. This is good to merge after PR geoschem/geos-chem#2244.
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR adds the ISOROPPIA II aerosol thermodynamics package with HETPv1.0 as a new git submodule. From the HETP README:
Note that this PR can be merged prior to updates in GEOS-Chem to use HETP without issue. However, it is required before the updates to GEOS-Chem in PR geoschem/geos-chem#2244.
This update makes a minor no-diff update to change the name of the HEMCO_GridComp folder to HEMCO. This avoids confusion about whether HEMCO is a gridded component (it is not).
Expected changes
Preliminary 1-month full chemistry benchmarks comparing ISORROPIA with HETPv1.0 in GEOS-Chem are posted here.
Reference(s)
See https://gmd.copernicus.org/articles/17/2197/2024/gmd-17-2197-2024-discussion.html
Related Github Issue(s)