Update code in carbon_gases_mod.F90 for consistency with config file updates from PR #1916 #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeosCore/carbon_gases_mod.F90 - Rename useGlobOH module variable to useGlobOHbmk10yr, in order to better clarify that this indicates we are using OH from a recent 10-year benchmark. - Update IF block logic where GLOBAL_OH variable is evaluated from HEMCO. The IF block now needs to execute if either OH from the 10yr benchmark or OH from version 5 is selected. Previously, the OH from version 5 block was nested within the OH from the 10-yr benchmark block. - Remove ELSE statements - Update HEMCO option from "GLOBAL_OH" to "GLOBAL_OH_GC14". Also added a note to remind developers that this tag will have to be updated to be consistent with the option name in HEMCO_Config.rc. - Updated IF block logic where the informational message is printed as to which OH is being used. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
CHANGELOG.md - Add note about having to update carbon_gases_mod.F90 to be consistent with config file updates from PR #1916 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
specialty simulations
category: Bug Fix
msulprizio
approved these changes
Aug 29, 2023
|
Integration tests are running. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
While integration testing with PR #1916 and PR geoschem/HEMCO#235, we encountered an error in the carbon simulation:
This issue was traced to code in
GeosCore/carbon_gases_mod.F90that had not been updated to be consistent with the newGLOBAL_OH_GC14container that was introduced in PR #1916.We have now added updates so that the code in
GeosCore/carbon_gases_mod.F90now recognizes theGLOBAL_OH_GC14container. Some if-block logic has also been reworked.Expected changes
This will allow the carbon simulation to finish normally.
Related Github Issue(s)