Add Socket mode adapter as new default #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the RTM version of the adapter. Fixes #84
These were for local testing
The only use is to notify users that Gort is online, which is still supported with this change. This also removes the need to identify the bot user on startup, which is less straightforward in Socket mode.
| } | ||
|
|
||
| // OnChannelMessage is called when the Slack API emits an MessageEvent for a message in a channel. | ||
| func (s *ClassicAdapter) OnChannelMessage(event *slack.MessageEvent, info *adapter.Info) *adapter.ProviderEvent { |
There was a problem hiding this comment.
Note for the future: these OnFOO methods are exported in the classic adapter (though they really don't need to be), and unexported in the new adapter. We might want to make them consistent eventually.
There was a problem hiding this comment.
Makes sense, do we want a follow up issue for it?
clockworksoul
requested changes
Sep 7, 2021
Figured it would prevent us having to get those white space changes into another PR, or having to remember to revert every time we run the books until we touch those files again. |
|
SGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Classic Slack app is still supported, but results in a deprecation warning.
Socket mode is enabled by specifying the new
app_tokenandbot_tokenfields of theslackconfig yaml instead of the Classicapi_tokenfield.A manifest file is provided to configure a new Socket mode app with the appropriate scopes.
Fixes #84