Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic-sampling): Copy changes and doc links #80818

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(dynamic-sampling): Copy changes and doc links #80818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion static/app/views/settings/dynamicSampling/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {Fragment} from 'react';

import {Alert} from 'sentry/components/alert';
import {LinkButton} from 'sentry/components/button';
import SentryDocumentTitle from 'sentry/components/sentryDocumentTitle';
import {t} from 'sentry/locale';
import {hasDynamicSamplingCustomFeature} from 'sentry/utils/dynamicSampling/features';
Expand All @@ -20,7 +21,17 @@ export default function DynamicSamplingSettings() {
<Fragment>
<SentryDocumentTitle title={t('Dynamic Sampling')} orgSlug={organization.slug} />
<div>
<SettingsPageHeader title={t('Dynamic Sampling')} />
<SettingsPageHeader
title={t('Dynamic Sampling')}
action={
<LinkButton
external
href="https://docs.sentry.io/product/performance/retention-priorities/"
>
{t('Read the docs')}
</LinkButton>
}
/>
<p>
{t(
'Dynamic sampling adaptively reduces the number of spans stored in Sentry without changing SDK sample rates. It allows you to keep the most relevant samples and obtain accurate high-level insights while limiting redundancy and stored span volume. You can customize sample rates and priorities in these settings to control which data is stored.'
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/dynamicSampling/samplingBreakdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function SamplingBreakdown({sampleCounts, sampleRates, ...props}: Props)
return (
<div {...props}>
<Heading>
{t('Breakdown of stored spans')}
{t('Breakdown of stored spans originating in these projects')}
<SubText>{t('Total: %s', formatAbbreviatedNumber(total))}</SubText>
</Heading>
<Breakdown>
Expand Down
5 changes: 4 additions & 1 deletion static/app/views/settings/dynamicSampling/samplingModeSwitchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,11 @@ function SamplingModeSwitchModal({
}
)
: tct(
'Switching to manual mode disables automatic adjustments. After the switch, you can configure individual sample rates for each project. Dynamic sampling priorities continue to apply within the projects. [link:Learn more]',
'Switching to manual mode disables automatic adjustments. After the switch, you can configure individual sample rates for each project. [prioritiesLink:Dynamic sampling priorities] continue to apply within the projects. [link:Learn more]',
{
prioritiesLink: (
<ExternalLink href="https://docs.sentry.io/product/performance/retention-priorities/" />
),
link: (
<ExternalLink href="https://docs.sentry.io/product/performance/retention-priorities/" />
),
Expand Down
Loading