feat(metric-issues): Configure workflow notifications by group type #81609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
commented
Dec 3, 2024
| @@ -106,7 +106,7 @@ def test_unresolve_ignored_issue(self, issue_unignored: Any) -> None: | |||
| self.projects, | |||
| self.project_lookup, | |||
| acting_user=self.user, | |||
| is_bulk=True, | |||
| is_bulk=False, | |||
There was a problem hiding this comment.
Here and below, the tests were set up incorrectly.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81609 +/- ##
==========================================
+ Coverage 80.36% 80.49% +0.12%
==========================================
Files 7275 7258 -17
Lines 321402 322162 +760
Branches 20962 20805 -157
==========================================
+ Hits 258306 259331 +1025
+ Misses 62685 62432 -253
+ Partials 411 399 -12 |
snigdhas
changed the title
snigdhas
commented
Dec 3, 2024
Comment on lines
+1020
to
+1023
| if "status" not in kwargs: | ||
| kwargs["status"] = GroupStatus.UNRESOLVED | ||
| kwargs["substatus"] = GroupSubStatus.NEW | ||
|
|
There was a problem hiding this comment.
This fixes any "incorrect substatus for unresolved group" errors that stem from stricter group status validation
wedamija
approved these changes
Dec 12, 2024
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
…81609) Metric issues, and other detector-controlled issues, need the ability to disable workflow notifications for status changes (i.e. issue resolved/regressed/unresolved) while still sending workflow notifications for other changes to the issue such as assignments and comments. To support this cleanly, this PR adds a field to the GroupType dataclass to allow issue types to disable the status change workflow notifications. Issue activity notifications will continue to be sent for all issue types. For issue types that do not use the existing status change workflow notifications, the issue type will be responsible for sending these notifications. We use the new `enable_status_change_workflow_notifications` field to disable notifications for status-based activity types when activity.send_notification is called. Added a new test to confirm disables notifications for the MetricIssuePOC type and existing tests remain unaffected for error/other issue platform types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric issues, and other detector-controlled issues, need the ability to disable workflow notifications for status changes (i.e. issue resolved/regressed/unresolved) while still sending workflow notifications for other changes to the issue such as assignments and comments.
To support this cleanly, this PR adds a field to the GroupType dataclass to allow issue types to disable the status change workflow notifications. Issue activity notifications will continue to be sent for all issue types. For issue types that do not use the existing status change workflow notifications, the issue type will be responsible for sending these notifications.
We use the new
enable_status_change_workflow_notificationsfield to disable notifications for status-based activity types when activity.send_notification is called. Added a new test to confirm disables notifications for the MetricIssuePOC type and existing tests remain unaffected for error/other issue platform types.