Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-trace-issues): Updating designs for trace preview in issue details #83430

Merged
merged 3 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ describe('EventTraceView', () => {
render(
<EventTraceView group={perfGroup} event={perfEvent} organization={organization} />
);
expect(await screen.findByText('Trace')).toBeInTheDocument();
expect(await screen.findByText('Trace Preview')).toBeInTheDocument();
expect(
await screen.findByRole('link', {name: 'View Full Trace'})
).toBeInTheDocument();
Expand Down Expand Up @@ -192,6 +192,6 @@ describe('EventTraceView', () => {

render(<EventTraceView group={group} event={event} organization={organization} />);

expect(await screen.findByText('Trace')).toBeInTheDocument();
expect(await screen.findByText('Trace Preview')).toBeInTheDocument();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import styled from '@emotion/styled';
import type {LocationDescriptor} from 'history';

import {LinkButton} from 'sentry/components/button';
import ExternalLink from 'sentry/components/links/externalLink';
import Link from 'sentry/components/links/link';
import {generateTraceTarget} from 'sentry/components/quickTrace/utils';
import {IconOpen} from 'sentry/icons';
Expand All @@ -11,6 +12,7 @@ import type {Event} from 'sentry/types/event';
import {type Group, IssueCategory} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';
import {defined} from 'sentry/utils';
import {trackAnalytics} from 'sentry/utils/analytics';
import useRouteAnalyticsParams from 'sentry/utils/routeAnalytics/useRouteAnalyticsParams';
import {useLocation} from 'sentry/utils/useLocation';
import useOrganization from 'sentry/utils/useOrganization';
Expand Down Expand Up @@ -58,9 +60,15 @@ interface EventTraceViewInnerProps {
event: Event;
organization: Organization;
traceId: string;
traceTarget: LocationDescriptor;
}

function EventTraceViewInner({event, organization, traceId}: EventTraceViewInnerProps) {
function EventTraceViewInner({
event,
organization,
traceId,
traceTarget,
}: EventTraceViewInnerProps) {
const timestamp = new Date(event.dateReceived).getTime() / 1e3;

const trace = useTrace({
Expand Down Expand Up @@ -108,7 +116,14 @@ function EventTraceViewInner({event, organization, traceId}: EventTraceViewInner
replay={null}
event={event}
/>
<IssuesTraceOverlay event={event} />
<IssuesTraceOverlayContainer
href={getHrefFromTraceTarget(traceTarget)}
onClick={() => {
trackAnalytics('issue_details.view_full_trace_waterfall_clicked', {
organization,
});
}}
/>
</IssuesTraceContainer>
</TraceStateProvider>
);
Expand All @@ -129,39 +144,6 @@ function getHrefFromTraceTarget(traceTarget: LocationDescriptor) {
return `${traceTarget.pathname}?${searchParams.toString()}`;
}

function IssuesTraceOverlay({event}: {event: Event}) {
const location = useLocation();
const organization = useOrganization();

const traceTarget = generateTraceTarget(
event,
organization,
{
...location,
query: {
...location.query,
groupId: event.groupID,
},
},
TraceViewSources.ISSUE_DETAILS
);

return (
<IssuesTraceOverlayContainer>
<LinkButton
size="sm"
icon={<IconOpen />}
href={getHrefFromTraceTarget(traceTarget)}
external
analyticsEventName="Issue Details: View Full Trace"
analyticsEventKey="issue_details.view_full_trace"
>
{t('View Full Trace')}
</LinkButton>
</IssuesTraceOverlayContainer>
);
}

function OneOtherIssueEvent({event}: {event: Event}) {
const location = useLocation();
const organization = useOrganization();
Expand Down Expand Up @@ -200,52 +182,69 @@ const IssuesTraceContainer = styled('div')`
position: relative;
`;

const IssuesTraceOverlayContainer = styled('div')`
const IssuesTraceOverlayContainer = styled(ExternalLink)`
position: absolute;
inset: 0;
z-index: 10;

a {
display: none;
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
}

&:hover {
background-color: rgba(128, 128, 128, 0.4);

a {
display: block;
}
}
`;

interface EventTraceViewProps extends Omit<EventTraceViewInnerProps, 'traceId'> {
interface EventTraceViewProps {
event: Event;
group: Group;
organization: Organization;
}

export function EventTraceView({group, event, organization}: EventTraceViewProps) {
const traceId = event.contexts.trace?.trace_id;
const location = useLocation();

if (!traceId) {
return null;
}

const traceTarget = generateTraceTarget(
event,
organization,
{
...location,
query: {
...location.query,
groupId: event.groupID,
},
},
TraceViewSources.ISSUE_DETAILS
);

const hasProfilingFeature = organization.features.includes('profiling');
const hasTracePreviewFeature =
hasProfilingFeature &&
// Only display this for error or default events since performance events are handled elsewhere
group.issueCategory !== IssueCategory.PERFORMANCE;

return (
<InterimSection type={SectionKey.TRACE} title={t('Trace')}>
<InterimSection
type={SectionKey.TRACE}
title={t('Trace Preview')}
actions={
<LinkButton
size="xs"
icon={<IconOpen />}
href={getHrefFromTraceTarget(traceTarget)}
external
analyticsEventName="Issue Details: View Full Trace Action Button Clicked"
analyticsEventKey="issue_details.view_full_trace_action_button_clicked"
>
{t('View Full Trace')}
</LinkButton>
}
>
<OneOtherIssueEvent event={event} />
{hasTracePreviewFeature && (
<EventTraceViewInner
event={event}
organization={organization}
traceId={traceId}
traceTarget={traceTarget}
/>
)}
</InterimSection>
Expand Down
3 changes: 3 additions & 0 deletions static/app/utils/analytics/issueAnalyticsEvents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export type IssueEventParameters = {
'issue_details.streamline_ui_toggle': {
isEnabled: boolean;
};
'issue_details.view_full_trace_waterfall_clicked': {};
'issue_details.view_hierarchy.hover_rendering_system': {
platform?: string;
user_org_role?: string;
Expand Down Expand Up @@ -453,6 +454,8 @@ export const issueEventMap: Record<IssueEventKey, string | null> = {
'Issue Group Details: Tags distribution value bar clicked',
'integrations.integration_reinstall_clicked': 'Integration Reinstall Button Clicked',
'one_other_related_trace_issue.clicked': 'One Other Related Trace Issue Clicked',
'issue_details.view_full_trace_waterfall_clicked':
' Issue Details: View Full Trace Waterfall Clicked',

// Performance Issue specific events here
'issue_details.performance.autogrouped_siblings_toggle':
Expand Down
Loading