Adding Hashicorp vault support #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial work on integration feat(vault): added cli coomands working for vualt" fix(vault): fixed config with correct tests fix(vault): added vault to keygroup and to keyservice server fixed metadata load
fix(doc): fix rst formatting" fix(doc): fix rst formatting
feat(cli): moved vault to hc-vault naming
additional to URIs
Signed-off-by: vnzongzna <github@vaibhavk.in>
Signed-off-by: vnzongzna <github@vaibhavk.in>
Codecov Report
@@ Coverage Diff @@
## develop #655 +/- ##
===========================================
+ Coverage 37.11% 38.18% +1.06%
===========================================
Files 21 23 +2
Lines 2891 3326 +435
===========================================
+ Hits 1073 1270 +197
- Misses 1724 1927 +203
- Partials 94 129 +35
Continue to review full report at Codecov.
|
autrilla
suggested changes
Apr 21, 2020
Co-Authored-By: Adrian Utrilla <adrianutrilla@gmail.com>
Co-Authored-By: gitirabassi Co-Authored-By: ldue Signed-off-by: vnzongzna <github@vaibhavk.in>
|
Is there any information on when we can expect this in a release? For now, I am manually compiling the binaries in my docker file, but that is not ideal. |
|
Yea, we are also interested that a new release is created so we can use this feature via the official binaries. |
rochaporto
pushed a commit
to rochaporto/sops
that referenced
this pull request
Jun 22, 2020
* feat: initial adding of vualt transit backend to sops initial work on integration feat(vault): added cli coomands working for vualt" fix(vault): fixed config with correct tests fix(vault): added vault to keygroup and to keyservice server fixed metadata load * feat(docs): added docs in README.md and in command help fix(doc): fix rst formatting" fix(doc): fix rst formatting * fix(vault): addressed typos and fixes from autrilla feat(cli): moved vault to hc-vault naming * fix(test): typo while rebasing * fix typos and imporve error messages for vault kms * rename package from vault to hcvault * refactor vault keysource url validation * add negative test cases for vault keysource * add hc vault transit config option via objects additional to URIs * remove vault_example.yml * streamline key name to snake case * rename `BackendPath` to `EnginePath` for hc vault * correction in hc-vault-transit commands Signed-off-by: vnzongzna <github@vaibhavk.in> * resolving conflict Signed-off-by: vnzongzna <github@vaibhavk.in> * Apply suggestions from code review Co-Authored-By: Adrian Utrilla <adrianutrilla@gmail.com> * allowing only hc_vault_transit_uri as input Co-Authored-By: gitirabassi Co-Authored-By: ldue Signed-off-by: vnzongzna <github@vaibhavk.in> Co-authored-by: gitirabassi <giacomo@tirabassi.eu> Co-authored-by: ldue <larsduennwald@gmail.com> Co-authored-by: Vaibhav Kaushik <vaibhavkaushik@vaibhavka-ltm1.internal.salesforce.com> Co-authored-by: Adrian Utrilla <adrianutrilla@gmail.com>
This was referenced Jul 2, 2020
seh
reviewed
Feb 24, 2021
| creation_rules: | ||
| - path_regex: \.dev\.yaml$ | ||
| hc_vault_transit_uri: "$VAULT_ADDR/v1/sops/keys/secondkey" | ||
| - path_regex: \.prod\.yaml$ |
There was a problem hiding this comment.
Was this regular expression supposed to match the file paths mentioned on line 348 below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #623