fix(webgpu): Insert fragment constants into fragment descriptor #7621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Apr 30, 2025
cwfitzgerald
added
the
PR: needs back-porting
Wumpf
pushed a commit
that referenced
this pull request
May 24, 2025
Wumpf
pushed a commit
to Wumpf/wgpu
that referenced
this pull request
May 24, 2025
|
backported to v24 in: but not v25 line yet. |
Wumpf
added a commit
to Wumpf/wgpu
that referenced
this pull request
May 24, 2025
…ad of vertex (gfx-rs#7621) (gfx-rs#7722) Co-authored-by: David Lenaerts <550217+DerSchmale@users.noreply.github.com>
Merged
Wumpf
removed
the
PR: needs back-porting
Wumpf
added a commit
that referenced
this pull request
May 24, 2025
Co-authored-by: David Lenaerts <550217+DerSchmale@users.noreply.github.com> Co-authored-by: RedMindZ <tavtaor11@gmail.com> Co-authored-by: Kevin Reid <kpreid@switchb.org> fix(webgpu): Insert fragment constants into fragment descriptor instead of vertex (#7621) (#7722) Fixed a deadlock caused by locking the device's snatchable lock **after** locking the queue's pending writes (#7582) Fix `raw-window-handle` dependency being too lenient (#7526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
create_render_pipeline, thefrag.compilation_options.constantswere mistakenly inserted intomapped_vertex_stateinstead ofmapped_fragment_desc, causing override constants to fail in the fragment shader.Testing
A shader was used to conditionally sample a texture to use as color output, otherwise output white. Did not work before, but does now.
Squash or Rebase?
Not applicable.