Check out what I did! #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2011 16:38
Added lookup for dotGitDirectory to check current dir, project/.git and parent/.git
TheSnoozer
pushed a commit
to TheSnoozer/git-commit-id-maven-plugin
that referenced
this pull request
Jun 7, 2016
…tIdMojoDirtyFilesTest has been moved to GitCommitIdMojoIntegrationTest, since the determination of the dirty state should work regardless of native or the jgit implementation. Fix git-commit-id#2: The FileSystemMavenSandbox is intended to just be able to copy the git-Repository itself. As a result having the files besides the repository does no make sense. With that being said the repositories _git_with_no_changes and _git_with_changes needed to be refactored. Since the FileSystemMavenSandbox just copies the git-Repository itself all the repositories are dirty by default as long as they have files tracked. Hence the new _git_with_no_changes currently does no have files in it to be able to represent a repository with no changes. Fix git-commit-id#3 (git-commit-id#236): The ProcessBuilder inside NativeGitProvider always told the user that the 'git status -s' command was not issued correctly and printed the usage manual of the command itself. Since the 'git status -s' command just checks if there was a return value from the command the NativeGitProvider always assumed that the repository was in a dirty state....
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.