#346 / #336 / #350: Drop Java 1.7 support / introduce a timeout for any native git command / replace almost every guava feature with Java 8 features #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 31, 2018 17:54
…ced with ArgumentMatchers
…s' that allows to specify a timeout for any call to the native binary in case of issues while fetching information
…ist what needs to be updated
added 8 commits
August 31, 2018 20:45
… error prone to java9 and newer java versions (as a result now also rely on a single checkstyle 8.2 definition)
TheSnoozer
commented
Sep 1, 2018
pom.xml
Outdated
| <artifactId>annotations</artifactId> | ||
| <version>12.0</version> | ||
| <version>16.0.2</version> | ||
| </dependency> |
There was a problem hiding this comment.
Alternatively we could use
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
<version>3.0.2</version>
</dependency>However, technically I don't see a huge benefit in changing this...the findbugs one might look more native java like...
added 4 commits
September 1, 2018 13:26
- replace com.google.common.base.Optional with java.util.Optional
- replace com.google.common.base.Joiner with java.util.StringJoiner or String.join
- replace com.google.common.base.MoreObjects with java.util.Optional
- replace Preconditions.checkArgument(arg != null, ...) with java.util.Objects.requireNonNull(arg)
- replace various com.google.common.base.{Function, Predicate, Predicates} code snippets with lambda expressions
- replace com.google.common.io.Closeables with java's try-with-resources
TheSnoozer
changed the title
added 2 commits
September 1, 2018 19:19
…arname itself; use try-with-resources instead of closing resources with finally; lambda call simplifications)
…5 (annotations that come automatically with guava)
TheSnoozer
commented
Sep 4, 2018
| } | ||
| return false; | ||
| }) | ||
| .map(tagRef -> tagRef.getName().replaceAll("refs/tags/", "")) |
There was a problem hiding this comment.
Why not use trimFullTagName(tagRef.getName()) here?
This specific Method would use replaceFirst("refs/tags/", "") instead of replaceAll. However AFAIK we are expecting only the start to be refs/tags/.... I think a replaceAll would prevent us from using actual tags that are looking like refs/tags/... (very unlikely that this ever happens). In practice I wouldn't assume it actually makes a difference.
added 2 commits
September 4, 2018 22:22
…lt' variable declaration to set them directly inside the tests
…lates based on the circumstances - aka. one template for bugs, one for features and one general template (see https://help.github.com/articles/about-issue-and-pull-request-templates/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changing with this MR: