Add timeouts for commit hooks #2547
Draft
+192
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening early as a draft. Initial changes are working and have tests added for them just need to figure out how we are going to implement a timeout value, if thats user configuration or a default impl. |
|
Was wanting to get some feedback on this before progressing further, is this the correct place to implement the timeout logic? @extrawurst |
|
This would impact other users like Gitbutler. @Byron what do you think about this change? |
cruessler
reviewed
Mar 15, 2025
|
|
||
| let res = hooks_pre_commit( | ||
| &root.to_str().unwrap().into(), | ||
| Duration::ZERO, |
There was a problem hiding this comment.
Should this be a non-zero value? At least, I was expecting a non-zero value based on the test’s name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #2546.
It changes the following:
I followed the checklist:
make checkwithout errors