Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss commit msg key #2563

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dismiss commit msg key #2563

wants to merge 4 commits into from
+3 −2

Conversation

wessamfathi
Copy link

This Pull Request fixes/closes #2552.

It changes the following:

  • The default key to close the commit error message popup is now the Escape key

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@naseschwarz
Copy link
Contributor

I tested this and the escape key works.

@naseschwarz
Copy link
Contributor

The command legend is still set to Enter, though:

image

You probably also want to update MsgPopup::commands, replace strings::commands::close_msg by strings::commands::close_popup.

@extrawurst extrawurst requested a review from naseschwarz March 15, 2025 08:46
@wessamfathi
Copy link
Author

Good catch. I submitted a fix.

naseschwarz
naseschwarz approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@naseschwarz naseschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change. I tested it again. It still works fine and displays the correct symbol in the legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naseschwarz naseschwarz naseschwarz approved these changes

Assignees
No one assigned
Labels
merge_ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Also support escape for dismissing commit error message
3 participants
@wessamfathi @naseschwarz @extrawurst