-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert "feat(gnoweb): add metadata to md content (#3797)" #3924
base: master
Are you sure you want to change the base?
Conversation
This reverts commit d1db75e.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
fsigs, err := h.Client.Functions(gnourl.Path) | ||
if err != nil { | ||
h.Logger.Error("unable to fetch path functions", "error", err) | ||
return GetClientErrorStatusPage(gnourl, err) | ||
} | ||
|
||
// HTML Head metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moul Should we keep these ones at least (default ones for source, actions, dir)? There is no UGC in those one (so no UGC risk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can keep whatever you want. I tried to manage conflicts, but I'm not very familiar with this feature. I offer you two choices: continue working on my pull request to improve it, or we can merge this revert and you can focus on SEO optimizations later.
This reverts commit d1db75e (#3797).
See #3910.
Let's revert this now. Then we can try to improve SEO automatically by extracting the first H1 and the first paragraph, as this PR did manually. After that, we should take more time to consider aspects such as frontmatter and everything involved in allowing developers to specify "invisible" elements.