Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "feat(gnoweb): add metadata to md content (#3797)" #3924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moul
Copy link
Member

@moul moul commented Mar 12, 2025

This reverts commit d1db75e (#3797).
See #3910.

Let's revert this now. Then we can try to improve SEO automatically by extracting the first H1 and the first paragraph, as this PR did manually. After that, we should take more time to consider aspects such as frontmatter and everything involved in allowing developers to specify "invisible" elements.

@moul moul self-assigned this Mar 12, 2025
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Mar 12, 2025
@Gno2D2 Gno2D2 requested review from alexiscolin and gfanton March 12, 2025 12:31
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 12, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes related to gnoweb must be reviewed by its codeowners

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/handler.go)

Then

🟢 Requirement satisfied
└── 🟢 Or
    ├── 🟢 This user reviewed pull request: alexiscolin
    └── 🔴 This user reviewed pull request: gfanton

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul changed the title Revert "feat(gnoweb): add metadata to md content (#3797)" chore: revert "feat(gnoweb): add metadata to md content (#3797)" Mar 12, 2025
@moul moul added the security Security-sensitive issue label Mar 12, 2025
@moul moul requested a review from kristovatlas March 12, 2025 12:33
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

fsigs, err := h.Client.Functions(gnourl.Path)
if err != nil {
h.Logger.Error("unable to fetch path functions", "error", err)
return GetClientErrorStatusPage(gnourl, err)
}

// HTML Head metadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul Should we keep these ones at least (default ones for source, actions, dir)? There is no UGC in those one (so no UGC risk)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can keep whatever you want. I tried to manage conflicts, but I'm not very familiar with this feature. I offer you two choices: continue working on my pull request to improve it, or we can merge this revert and you can focus on SEO optimizations later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages. security Security-sensitive issue
Projects
Status: No status
Status: 📥 Inbox
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants