Skip to content

LDAP User Filter #10829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qequinet35 opened this issue Mar 26, 2020 · 4 comments · Fixed by #10869
Closed

LDAP User Filter #10829

qequinet35 opened this issue Mar 26, 2020 · 4 comments · Fixed by #10869
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@qequinet35
Copy link

qequinet35 commented Mar 26, 2020 •
edited
Loading

Dear all,

I am creating this issue because I found any topic related to this kind of filter using OpenLDAP.

In the official documentation (https://docs.gitea.io/en-us/authentication/), it is written that with "LDAP using simple auth" there are these following fields:
User DN (required)
User Search Base (optional)
User Filter (required)
Group Search Base (optional)
Group Name Filter (optional)
User Attribute in Group (optional)
Group Attribute for User (optional)

.... but I am not able to find the fields regarding the Groups from the Gitea Web Interface.

I used the following version of gitea: gitea-1.11.3-linux-amd64

Did I installed a wrong version ?

Could you please help me.

Thanks by advance,
Regards,
@jolheiser jolheiser mentioned this issue Mar 28, 2020
Merged
@zeripath
Copy link
Contributor

It looks we never implemented that despite it being in the docs for 2 years now... 🤦‍♂️

@stale
Copy link

stale bot commented May 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 29, 2020
@stale
Copy link

stale bot commented Jun 12, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Jun 12, 2020
@zeripath zeripath added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 12, 2020
@zeripath zeripath reopened this Jun 12, 2020
@stale stale bot removed the issue/stale label Jun 12, 2020
zeripath added a commit that referenced this issue Sep 10, 2020
@jolheiser @zeripath
Add check for LDAP group membership (#10869)
c3e8c94 
This is a port of gogs/gogs#4398

The only changes made by myself are:

Add locales
Add some JS to the UI
Otherwise all code credit goes to @aboron

Resolves #10829

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
@Elbandi
Copy link

Elbandi commented Nov 7, 2020

Look like the group check is missing from SearchEntries()

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check for LDAP group membership jolheiser/gitea
3 participants
@Elbandi @zeripath @qequinet35