Skip to content

Improve federated avatars DNS lookups #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strk opened this issue Mar 16, 2017 · 2 comments
Closed

Improve federated avatars DNS lookups #1287

strk opened this issue Mar 16, 2017 · 2 comments
Labels
issue/stale type/enhancement An improvement of existing functionality

Comments

@strk
Copy link
Member

strk commented Mar 16, 2017

At the moment enabling FEDERATED_AVATARS results in some delays whenever the server has to provide the URL to the avatar of users whose federated avatar url is not found in the ad-hoc cache (which has 1 day of lifetime).

While this may not be a big deal in a page with a single user, explore/users page can show many users and if these have emails with many different domains the delay sums up until browser possibly times out.

The situation may be improved in various ways:

  1. Make sure multiple thread asking for the same domain lookup all queue so that a single lookup is ever performed (but I'd think the operating system should already being taking care of this)
  2. Always perform the lookup in the background and save the result in db tables

In any case it would be useful to document the problem with the setting that enables these.

@lunny lunny added this to the 2.x.x milestone Mar 17, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 17, 2017
@stale
Copy link

stale bot commented Feb 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 16, 2019
@stale
Copy link

stale bot commented Mar 2, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Mar 2, 2019
@lunny lunny removed this from the 2.x.x milestone Apr 4, 2019
techknowlogick pushed a commit that referenced this issue Sep 6, 2019
* feat: highlight issue references with :

e.g. #1287: my commit msg
e.g. ABC-1234: my commit msg

* ref: update model regex to consistent with issueNumericPattern

* test: check highlight issue with : in commits messages
6543 pushed a commit to 6543-forks/gitea that referenced this issue Oct 6, 2019
* feat: highlight issue references with :

e.g. go-gitea#1287: my commit msg
e.g. ABC-1234: my commit msg

* ref: update model regex to consistent with issueNumericPattern

* test: check highlight issue with : in commits messages
techknowlogick pushed a commit that referenced this issue Oct 7, 2019
* feat: highlight issue references with :

e.g. #1287: my commit msg
e.g. ABC-1234: my commit msg

* ref: update model regex to consistent with issueNumericPattern

* test: check highlight issue with : in commits messages
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants