Skip to content

Assigning an issue does not send an email if user's notifications are set to "Only on Mention" #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greatawesome opened this issue Dec 2, 2021 · 1 comment · Fixed by #18707
Closed

Assigning an issue does not send an email if user's notifications are set to "Only on Mention" #17892

greatawesome opened this issue Dec 2, 2021 · 1 comment · Fixed by #18707
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.17.0

Comments

@greatawesome
Copy link

greatawesome commented Dec 2, 2021 •
edited
Loading

Feature Description

It would be ideal if assigning a user an issue (as per #8233 and #8546) would be considered a "mention" for the purposes of sending email notifications.

Screenshots

No response
@noerw noerw added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 4, 2021
@flozzone
Copy link
Contributor

came across this too now. would be very helpful and users expect a notification email when they got assigned also if they've On mention setting enabled.

@6543 6543 added this to the 1.17.0 milestone Feb 10, 2022
flozzone added a commit to flozzone/gitea that referenced this issue Feb 10, 2022
@flozzone
Send mail to issue/pr assignee/reviewer also when onmention is set (g…
3c15100 
…o-gitea#17892)
@flozzone flozzone mentioned this issue Feb 10, 2022
Merged
zeripath pushed a commit to zeripath/gitea that referenced this issue Feb 14, 2022
@flozzone @zeripath
Send mail to issue/pr assignee/reviewer also when OnMention is set (g…
e199b64 
…o-gitea#18707)

Backport go-gitea#18707

Addresses go-gitea#17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see go-gitea#17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

See go-gitea#12774 (comment)

Fix go-gitea#17892
@zeripath zeripath mentioned this issue Feb 14, 2022
Merged
lunny pushed a commit that referenced this issue Feb 14, 2022
@zeripath @flozzone
Send mail to issue/pr assignee/reviewer also when OnMention is set (#…
2e36ba0 
…18707) (#18765)

Backport #18707

Addresses #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

See #12774 (comment)

Fix #17892

Co-authored-by: flozzone <flozzone@gmail.com>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@flozzone
Send mail to issue/pr assignee/reviewer also when OnMention is set (g…
efc5e0e 
…o-gitea#18707)

I want to address go-gitea#17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see go-gitea#17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

go-gitea#12774 (comment)

Fix go-gitea#17892
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

Send mail to issue/pr assignee/reviewer also when onmention is set flozzone/gitea
4 participants
@flozzone @noerw @6543 @greatawesome