Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Audio Stream Player Gizmo Performance #104016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiroxas
Copy link
Contributor

@kiroxas kiroxas commented Mar 12, 2025

Same as Capsule, Sphere and Cylinder PRs.

Gained around 30k cycles (20k cycles for the billboard circle, and 10k for the emission angle), that will be better spent elsewhere.

@kiroxas kiroxas requested a review from a team as a code owner March 12, 2025 10:15
@kiroxas kiroxas force-pushed the improveAudioStreamPlayerGizmoPerformance branch 4 times, most recently from 39eac36 to 70f2a4a Compare March 12, 2025 10:31
@AThousandShips AThousandShips added this to the 4.x milestone Mar 12, 2025
ProfessorOctopus added a commit to ProfessorOctopus/godot that referenced this pull request Mar 14, 2025
A little cleanup.
Fix Invalid Task ID error spam in PipelineHashMapRD. godotengine#104044 by bruvzg
Fix LoadToken memory leak caused by unused resources obtained using load_threaded_request() godotengine#104008 by AlexOtsuka
Improve Audio Stream Player Gizmo Performance godotengine#104016 by kiroxas
Improve capsule gizmo performance godotengine#101533 by kiroxas
Switch occlusion culling to be based on depth instead of Euclidean distance godotengine#103798 by Rudolph-B
@kiroxas kiroxas force-pushed the improveAudioStreamPlayerGizmoPerformance branch from 70f2a4a to df44527 Compare March 16, 2025 12:42
@kiroxas kiroxas force-pushed the improveAudioStreamPlayerGizmoPerformance branch from df44527 to e0b777f Compare March 16, 2025 12:47
@smix8 smix8 modified the milestones: 4.x, 4.5 Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants