Defend against directories without trailing slashes #104022
Open
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103992
FileSystemDock::create_directory
can get called with abase_dir
that don't have a trailing slash in a couple ways. It seemed like a footgun for it to require a trailing slash, so I fixed the issue by making it tolerant to either formatting.After that, I audited similar usages of trim combined with paths in the rest of the codebase since this seems like an easy mistake to make, and the editor_file_system change addresses the only one that seemed similarly easy to make a mistake with and is a cheap enough addition it seemed reasonable to add defensively.
This largely occurs because
String::get_base_dir
returns a result without a trailing slash. Since this is also abase_dir
, it seems like it should accept things straight fromString::get_base_dir
.