Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Fix dragging unselected item when a selection already exists #104032

Merged

Conversation

Aryombre
Copy link
Contributor

Trying to close 103858
After investigating this was not linked to parenting but instead to selected tree items.
I discussed on godot contributor chat and this was not expected behaviour (see GIF)
Drag
It should now be working properly

@Aryombre Aryombre requested a review from a team as a code owner March 12, 2025 14:18
@KoBeWi KoBeWi added this to the 4.5 milestone Mar 12, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Mar 12, 2025

The commits need to be squashed into 1.

@Aryombre Aryombre force-pushed the 103858-fix-drag-unselected-tree-item branch from d424a65 to eeb46b7 Compare March 12, 2025 23:51
@akien-mga akien-mga changed the title Fix dragging tree items Tree: Fix dragging unselected item when a selection already exists Mar 13, 2025
@Repiteo Repiteo merged commit 86a0433 into godotengine:master Mar 13, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 13, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@Aryombre Aryombre deleted the 103858-fix-drag-unselected-tree-item branch March 13, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging parent node with selected children will instead drag the children
3 participants