env/openbsd-amd64: use version 6.3, make disklabel readable #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

blackgnezdo wants to merge 5 commits into golang:master from blackgnezdo:master

Contributor

blackgnezdo commented Sep 3, 2018 •

edited

Loading

Updates golang/go#26833

Restrictive root umask prevented ftp running as unprivileged user from reading disklabel file.

Greg Steuck added 4 commits

September 3, 2018 12:49


          Document the packages to install on Debian to build OpenBSD image.

9440a57


          Resolve ftp Permission denied due to install running it as unpriv.


          Use https instead of http.

66bd7ba


          Use OpenBSD 6.3.

3e19370

googlebot added the cla: yes label

Contributor

gopherbot commented Sep 3, 2018

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 3, 2018

Message from Gerrit User 5206:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 3, 2018

Message from Gerrit User 29087:

Patch Set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 3, 2018

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 3, 2018

Message from Gerrit User 29087:

Patch Set 2:

First time trying to use gerrit here, please bear with me.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!


          Apply the published patches.

99fd276

Contributor

gopherbot commented Sep 4, 2018

Message from Gerrit User 5065:

Patch Set 4:

You can't mix use of Gerrit & GitHub PRs. The GitHub PR importer bot will fight you (and win).

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 4, 2018

Message from Gerrit User 5065:

Patch Set 4:

Please add to the commit message:

Updates golang/go#26833

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

blackgnezdo changed the title ~~Fix up OpenBSD image building~~ env/openbsd-amd64: use version 6.3, make disklabel readable

Contributor

gopherbot commented Sep 4, 2018

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 4, 2018

Message from Gerrit User 12446:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 4, 2018

Message from Gerrit User 12446:

Uploaded patch set 7: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/133115.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          env/openbsd-amd64: use version 6.3, make disklabel readable

c2cb18f

Updates golang/go#26833

Restrictive root umask prevented ftp running as unprivileged user from reading disklabel file.

Change-Id: I40b2d5b29881ea3733d245f7705cf33c73d4f7dd
GitHub-Last-Rev: 99fd276
GitHub-Pull-Request: #12
Reviewed-on: https://go-review.googlesource.com/133115
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

Contributor

gopherbot commented Sep 4, 2018

This PR is being closed because golang.org/cl/133115 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels