x/tools/gopls: no diagnostics received for initially empty files (sometimes) #39646

myitcv · 2020-06-17T11:19:33Z

What version of Go are you using (`go version`)?

$ go version
go version devel +d286e61b67 Mon Jun 15 23:29:23 2020 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20200617042924-7f3f4b10a808
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20200617042924-7f3f4b10a808

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build538522998=/tmp/go-build -gno-record-gcc-switches"

What did you do?

govim has a test that verifies we receive expected diagnostics in the case where files are initially empty on disk, but subsequently get populated with content in the editor.

https://github.com/govim/govim/blob/e2a1802131f331832d667736aa27f023636f0c3a/cmd/govim/testdata/scenario_default/quickfix_empty_files.txt

Recently (apologies, I can't be any more specific than saying "in the last 2-3 weeks) we have started to see, and continue to see, a small number of flakes in this test.

In a normal run of this test we expect a set of diagnostics; when we see these flakes, we don't see any diagnostics.

Here is a gopls log file from a passing test run. Notice the DidChange notifications, as well as the PublishDiagnostics notifications: gopls.log

And here is the gopls log from a failing test run. Notice the DidChange notifications, but no PublishDiagnostics notifications: gopls.log

What did you expect to see?

A consistently passing test.

What did you see instead?

Flakes as described above.

cc @stamblerre @findleyr

FYI @leitzler

The text was updated successfully, but these errors were encountered:

myitcv · 2020-06-25T09:27:43Z

FYI we're still seeing ~1 failure per day (in a build matrix of 12 entries) in the govim gopls@master build runs.

stamblerre · 2020-06-25T22:39:02Z

Thanks for the report! I am going to convert this into a gopls regression test and see if I can reproduce the issue.

gopherbot · 2020-06-26T00:02:44Z

Change https://golang.org/cl/240063 mentions this issue: internal/lsp: add a new regtest to reproduce golang/go#39646

stamblerre · 2020-06-26T00:14:50Z

I tried to reproduce the test as carefully as possible in my CL, but I haven't been able to trigger the failure. The issue is that the new files are getting treated like command-line-arguments packages, which should only happen when they are empty. I wonder if we will see similar flakes on the builders.

In the logs, I see command-line-arguments in the packages.Load at snapshot 3, which is the point at which p/p.go should be in a good state. I don't see any packages.Load results for snapshot 1, which is when you might expect a command-line-arguments result. One more thing to try would be adding an analogous go/packages test.

Change-Id: I51d8c66a83ecae1c8fc1f39c0e90a03a732c263b Reviewed-on: https://go-review.googlesource.com/c/tools/+/240063 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>

gopherbot · 2020-06-26T04:34:32Z

Change https://golang.org/cl/240098 mentions this issue: internal/lsp: reproduce and fix golang/go#39646

* gopls/internal/hooks, internal/lsp/source: only match full words in link regexes 0cc1aa72 * internal/lsp: support opening single files f01a4bec * internal/lsp/regtest: add regression tests for on-disk file changes ea7be8d7 * gopls/doc/troubleshooting.md: update the gopls output channel name 7cb253f4 * internal/lsp/source: speed up completion candidate formatting 1837592e * internal/lsp/cmd: change pre-filled issue header for gopls bug 9a0e0698 * internal/lsp: decorate error message from workspace/configuration a32c0cb1 * go/packages: move all overlay tests into overlay_test.go c138986d * internal/lsp: remove VS Code-specific completion hack b2d8b033 * internal/lsp/cache: handle a few possible panics in PackageStats 4bdfe1a3 * internal/analysisinternal: prevent fillstruct panic on nil package aa3d5013 * internal/lsp/source: add a new symbolStyle configuration option aa94e735 * internal/lsp: fully qualify workspace Symbol matches 84cfedeb * internal/lsp: add a new regtest to reproduce golang/go#39646 bcbc01e0 * internal/lsp/fake: explicitly set GOPACKAGESDRIVER=off in regtests 6506e20d * internal/lsp: watch all files in the module and replace target fadf93ff

* internal/lsp/lsprpc: improvements to daemon logging f2c07d7d * internal/lsp/regtest: simpler way to invert options cf799cae * internal/lsp: don't keep track of closed overlays 43ed9469 * internal/lsp: fix error in CL 242457 e66011cb * internal/lsp: clean up the code lens code a8f9df4c * internal/lsp: refactor generate code lens code c80dc571 * go/packages: add x test overlay test 130c9f19 * internal/lsp: add an importShortcut configuration ddb87c8c * internal/lsp: handle nil pointer in PackageStats 4cea8971 * internal/lsp/source: handle nil pointer in newBuiltinSignature b42590c1 * internal/lsp: avoid panic caused by assuming file ends with newline 9048b464 * internal/lsp: always show signature as the top line in hover 6acd2ab8 * gopls, internal/lsp: support an extra formatting hook for gofumpt 62a0bb78 * internal/lsp: add changeMethods logic to rename check f8240f79 * internal/lsp/source: add Vendor to list of supported commands 01425d70 * internal/analysisinternal: do not initialize {Get,Set}TypeErrors f739c553 * internal/lsp: watch go.{mod,sum} files, as well as Go files fd294ab1 * internal/lsp/cmd: add a -vv flag for higher verbosity 7342f973 * internal/lsp, go/packages: reproduce and fix golang/go#39646 f1c4188a * internal/lsp: add new go.mod requires to files with unused require 125cc70a * internal/lsp: fix rename with Windows line endings 55a0fde5 * internal/lsp/regtest: standardize on 20s timeout e327e101 * internal/lsp/regtest: use a common directory for regtest sandboxes e404ca24 * internal/lsp/regtest: remove stray short timeout df98bc6d * internal/lsp/regtest: add a regtest for golang/go#39296 3544e8c9 * internal/lsp/cache: handle missing mod file 31b9a748 * internal/lsp: check if analysis enabled in convenience fixes 7370b034 * internal/lsp/regtest: await IWL before running tests 134513de * internal/lsp/source: disable fillstruct by default d5a74533 * internal/lsp/cache: fix race in RunProcessEnvFunc 065b96d3 * internal/lsp: extract highlighted selection to variable 9c9572d6 * internal/imports: require valid options, move LocalPrefix up 416e8f4f * internal/lsp/analysis/fillstruct: support anonymous structs 9e0a013e * cmd/goyacc: print newlines more consistently b22de682 * all: update dependencies in go.mod file 682c4542 * internal/lsp/source: handle nil pointer in comment completions 95bc2bdf

* internal/lsp: add a configuration to enable/disable links in hover 6ddee643 * internal/lsp: log errors for compute fix edits instead of returning d518495e * internal/lsp: refactor go.mod diagnostics to simplify the API 58eba7e7 * internal/lsp/lsprpc: improvements to daemon logging f2c07d7d * internal/lsp/regtest: simpler way to invert options cf799cae * internal/lsp: don't keep track of closed overlays 43ed9469 * internal/lsp: fix error in CL 242457 e66011cb * internal/lsp: clean up the code lens code a8f9df4c * internal/lsp: refactor generate code lens code c80dc571 * go/packages: add x test overlay test 130c9f19 * internal/lsp: add an importShortcut configuration ddb87c8c * internal/lsp: handle nil pointer in PackageStats 4cea8971 * internal/lsp/source: handle nil pointer in newBuiltinSignature b42590c1 * internal/lsp: avoid panic caused by assuming file ends with newline 9048b464 * internal/lsp: always show signature as the top line in hover 6acd2ab8 * gopls, internal/lsp: support an extra formatting hook for gofumpt 62a0bb78 * internal/lsp: add changeMethods logic to rename check f8240f79 * internal/lsp/source: add Vendor to list of supported commands 01425d70 * internal/analysisinternal: do not initialize {Get,Set}TypeErrors f739c553 * internal/lsp: watch go.{mod,sum} files, as well as Go files fd294ab1 * internal/lsp/cmd: add a -vv flag for higher verbosity 7342f973 * internal/lsp, go/packages: reproduce and fix golang/go#39646 f1c4188a * internal/lsp: add new go.mod requires to files with unused require 125cc70a * internal/lsp: fix rename with Windows line endings 55a0fde5 * internal/lsp/regtest: standardize on 20s timeout e327e101 * internal/lsp/regtest: use a common directory for regtest sandboxes e404ca24 * internal/lsp/regtest: remove stray short timeout df98bc6d * internal/lsp/regtest: add a regtest for golang/go#39296 3544e8c9 * internal/lsp/cache: handle missing mod file 31b9a748 * internal/lsp: check if analysis enabled in convenience fixes 7370b034 * internal/lsp/regtest: await IWL before running tests 134513de * internal/lsp/source: disable fillstruct by default d5a74533 * internal/lsp/cache: fix race in RunProcessEnvFunc 065b96d3 * internal/lsp: extract highlighted selection to variable 9c9572d6 * internal/imports: require valid options, move LocalPrefix up 416e8f4f * internal/lsp/analysis/fillstruct: support anonymous structs 9e0a013e * cmd/goyacc: print newlines more consistently b22de682 * all: update dependencies in go.mod file 682c4542 * internal/lsp/source: handle nil pointer in comment completions 95bc2bdf

myitcv · 2020-07-30T04:01:46Z

We've just seen this again using 6467de6. Same situation as described before, logs as follows:

stamblerre · 2020-09-09T03:50:12Z

@myitcv: Sorry for the delay on this. Are you still seeing this with gopls at master?

myitcv · 2020-09-10T07:52:25Z

@stamblerre - I've just submitted govim/govim@c8c4a6f to verify.

myitcv · 2020-09-10T09:57:24Z

This appears to still be flakey using 44a2922: we had two flakes in https://github.com/govim/govim/actions/runs/247768908

stamblerre · 2020-09-10T14:24:24Z

Is there a way to see the gopls logs associated with these failures?

stamblerre · 2020-09-10T14:27:10Z

Note to self--from the earlier logs, the pass case has packages.Loads at snapshots 0, 6, and 12, whereas fail also has a load at snapshot 3. The regression test currently loads at 0, 3, 6, 9, and 12.

leitzler · 2020-09-10T17:50:26Z

Is there a way to see the gopls logs associated with these failures?

They are available in the artifacts, for example (looking at the run Paul linked above) the artifact file:

ubuntu-latest_go1.13.12_vim_v8.2.0931.zip

With the failed test found in the archive as:
Test TestScripts/scenario_default/quickfix_empty_files =>
Log govim/cmd/govim/scenario_default/script-quickfix_empty_files/_tmp/gopls.log

stamblerre · 2020-11-11T21:51:53Z

I expect that these test failures were caused by the go/packages overlay support, but there is now native support for overlays in 1.16.

@leitzler, @myitcv: Do you know if this test is fixed with Go 1.16?

myitcv · 2020-11-12T08:03:01Z

We will setup a tip instance in our build matrix and try it out.

stamblerre · 2021-02-10T21:41:01Z

Closing this issue, as there hasn't been any activity on it for several months.
@myitcv: Please reopen this if it still remains a problem.

As golang/go#39646 is closed we now re-enable the skipped test.

myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Jun 17, 2020

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 17, 2020

gopherbot added this to the Unreleased milestone Jun 17, 2020

myitcv mentioned this issue Jun 17, 2020

cmd/govim: investigate scenario_default/quickfix_empty_files flake govim/govim#884

Open

stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Jun 17, 2020

leitzler mentioned this issue Jun 18, 2020

cmd/govim: track go.mod files govim/govim#895

Closed

stamblerre mentioned this issue Jun 30, 2020

cmd/go: support overlays in the go command #39958

Closed

akupila mentioned this issue Jul 3, 2020

deps: update x/tools and gopls to 0cc1aa72b347 govim/govim#901

Merged

gopherbot closed this as completed in golang/tools@f1c4188 Jul 10, 2020

stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 12, 2020

leitzler mentioned this issue Jul 16, 2020

deps: update x/tools and gopls to 6ddee643 govim/govim#908

Merged

myitcv reopened this Jul 30, 2020

stamblerre modified the milestones: gopls/v0.4.4, gopls/v1.0.0 Jul 30, 2020

stamblerre added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 9, 2020

stamblerre removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 11, 2020

stamblerre added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 11, 2020

stamblerre removed this from the gopls/vscode-go milestone Nov 22, 2020

stamblerre modified the milestones: gopls/unplanned, gopls/v1.0.0 Dec 16, 2020

stamblerre closed this as completed Feb 10, 2021

stamblerre removed this from the gopls/v1.0.0 milestone Feb 10, 2021

leitzler added a commit to govim/govim that referenced this issue Feb 10, 2021

test: re-enable quickfix_empty_files test

ac9165d

As golang/go#39646 is closed we now re-enable the skipped test.

leitzler mentioned this issue Feb 10, 2021

test: re-enable quickfix_empty_files test govim/govim#1041

Merged

leitzler added a commit to govim/govim that referenced this issue Feb 10, 2021

test: re-enable quickfix_empty_files test

f799101

As golang/go#39646 is closed we now re-enable the skipped test.

leitzler added a commit to govim/govim that referenced this issue Feb 10, 2021

test: re-enable quickfix_empty_files test

c770030

As golang/go#39646 is closed we now re-enable the skipped test.

leitzler added a commit to govim/govim that referenced this issue Feb 11, 2021

test: re-enable quickfix_empty_files test

d09c016

As golang/go#39646 is closed we now re-enable the skipped test.

leitzler added a commit to govim/govim that referenced this issue Feb 11, 2021

test: re-enable quickfix_empty_files test (#1041)

c8ad0d4

As golang/go#39646 is closed we now re-enable the skipped test.

golang locked and limited conversation to collaborators Feb 10, 2022

gopherbot added the FrozenDueToAge label Feb 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: no diagnostics received for initially empty files (sometimes) #39646

x/tools/gopls: no diagnostics received for initially empty files (sometimes) #39646

myitcv commented Jun 17, 2020

myitcv commented Jun 25, 2020 •

edited

Loading

stamblerre commented Jun 25, 2020

gopherbot commented Jun 26, 2020

stamblerre commented Jun 26, 2020 •

edited

Loading

gopherbot commented Jun 26, 2020

myitcv commented Jul 30, 2020

stamblerre commented Sep 9, 2020

myitcv commented Sep 10, 2020

myitcv commented Sep 10, 2020

stamblerre commented Sep 10, 2020

stamblerre commented Sep 10, 2020

leitzler commented Sep 10, 2020

stamblerre commented Nov 11, 2020

myitcv commented Nov 12, 2020

stamblerre commented Feb 10, 2021

x/tools/gopls: no diagnostics received for initially empty files (sometimes) #39646

x/tools/gopls: no diagnostics received for initially empty files (sometimes) #39646

Comments

myitcv commented Jun 17, 2020

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

myitcv commented Jun 25, 2020 • edited Loading

stamblerre commented Jun 25, 2020

gopherbot commented Jun 26, 2020

stamblerre commented Jun 26, 2020 • edited Loading

gopherbot commented Jun 26, 2020

myitcv commented Jul 30, 2020

stamblerre commented Sep 9, 2020

myitcv commented Sep 10, 2020

myitcv commented Sep 10, 2020

stamblerre commented Sep 10, 2020

stamblerre commented Sep 10, 2020

leitzler commented Sep 10, 2020

stamblerre commented Nov 11, 2020

myitcv commented Nov 12, 2020

stamblerre commented Feb 10, 2021

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

myitcv commented Jun 25, 2020 •

edited

Loading

stamblerre commented Jun 26, 2020 •

edited

Loading