Skip to content

x/website/go.dev/cmd/internal/site: TestGolden failing #47294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Jul 19, 2021 · 1 comment
Closed

x/website/go.dev/cmd/internal/site: TestGolden failing #47294

dmitshur opened this issue Jul 19, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Unreleased

Comments

@dmitshur
Copy link
Member

As visible on the build dashboard, TestGolden is failing starting with CL 335669:

--- FAIL: TestGolden (0.56s)
    site_test.go:27: Load 503.977427ms
    site_test.go:84: about/index.html <- OK!
    site_test.go:54: categories/index.html <- SKIP
    site_test.go:54: categories/index.xml <- SKIP
    site_test.go:84: copyright/index.html <- OK!
    site_test.go:84: index.html <- OK!
    site_test.go:54: index.xml <- SKIP
    site_test.go:89: js/searchBox.js: wrong bytes
FAIL
FAIL	golang.org/x/website/go.dev/cmd/internal/site	0.605s

CC @jamalc.
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Jul 19, 2021
@dmitshur dmitshur added this to the Unreleased milestone Jul 19, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/335969 mentions this issue: Revert "go.dev/_content: focus search input shortcut key"

@julieqiu julieqiu mentioned this issue Jul 20, 2021
Closed
@golang golang locked and limited conversation to collaborators Jul 20, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
Revert "go.dev/_content: focus search input shortcut key"
0f2318f 
This reverts CL 335669.

Reason for revert: broke tests.

Fixes golang/go#47294.

Change-Id: I55d156aa79b1f4c41a813e9087318d67079c862c
Reviewed-on: https://go-review.googlesource.com/c/website/+/335969
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot