Skip to content

x/tools: add a relui workflow to automate goimports stdlib regeneration #54377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Aug 10, 2022 · 6 comments
Closed

x/tools: add a relui workflow to automate goimports stdlib regeneration #54377

findleyr opened this issue Aug 10, 2022 · 6 comments
Assignees
@dle8
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Member

#38706 is a task that must be completed by the tools team for each Go release. It involves a minor edit and running go generate ./internal/imports within x/tools. In other words, it is an automation that should be straightforward to implement in the release team's relui workflow system, by defining a new task that creates the requisite CL.

Since we're interested in using relui for other automation, this seems like a good place to start.

CC @golang/tools-team
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 10, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2022
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 10, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/436515 mentions this issue: internal/task: add a relui workflow to automate goimports stdlib regeneration

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/442157 mentions this issue: internal/relui: extend VersionTasks feature to automate goimports stdlib regeneration

gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2022
internal/relui: extend VersionTasks feature to automate goimports std…
d781efd 
…lib regeneration

Add a new task in addSingleReleaseWorkflow that creates the stdlib regeneration CL for each Go release using func CreateUpdateStdlibIndexCL in VersionTasks.
CreateUpdateStdlibIndexCL fetches the latest go binaries, downloads the latest version of tools repo, and submit a CL whose diff is created by regenerating stdlib with `go generate ./internal/imports`.

For golang/go#54377.

Change-Id: I3d95a88def984dd677d49f38587bed298b3aeaea
Reviewed-on: https://go-review.googlesource.com/c/build/+/442157
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Dylan Le <dungtuanle@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/448715 mentions this issue: internal/relui: add output that registers CreateUpdateStdlibIndexCL

gopherbot pushed a commit to golang/build that referenced this issue Nov 30, 2022
internal/relui: add output that registers CreateUpdateStdlibIndexCL
98eb568 
For golang/go#54377

Change-Id: I7a2a4f3592a9386faa3ebc63df1b6dbbc1c6c0a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/448715
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dylan Le <dungtuanle@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@dmitshur dmitshur mentioned this issue Feb 1, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/464535 mentions this issue: internal/task: skip CreateUpdateStdlibIndexCL

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/464815 mentions this issue: cmd/relui: fix up goimports regeneration task, add one-off workflow

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 2, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/464915 mentions this issue: cmd/relui: add await step for goimports CL, remove ad-hoc workflow

@dmitshur dmitshur mentioned this issue Feb 2, 2023
Closed
gopherbot pushed a commit to golang/build that referenced this issue Feb 2, 2023
@dmitshur @gopherbot
cmd/relui: fix up goimports regeneration task, add one-off workflow
dd73d1b 
CL 442157 added a task at the end of the major Go release workflow to
mail a CL to x/tools. There were 3 new fields added to VersionTasks,
but cmd/relui only set one of them, which caused the task not to work
during the Go 1.20 release (go.dev/issue/58227). Due to an unrelated
issue in cmd/relui (go.dev/issue/58228), we didn't get the opportunity
to fix up the task and restart it, so it was skipped.

Set the 2 missing fields in cmd/relui, and add a temporary workflow to
trigger (and test out) the new functionality after the Go 1.20 release.

Also apply a few minor refinements to CreateUpdateStdlibIndexCL. Remove
the unused branch parameter, and avoid GetCurrentMajor to determine the
current major version. GetCurrentMajor will change its report from N to
N+1 sometime during the major Go release, after the tags are published.
We already know the major version in the workflow.

Fixes golang/go#58227.
For golang/go#54377.

Change-Id: I6377cdf051e4ea8628a88ac3f7eaf70651b34f72
Reviewed-on: https://go-review.googlesource.com/c/build/+/464815
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dmitshur dmitshur moved this to Done in Go Release Feb 7, 2023
@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dle8 dle8

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @gopherbot @thanm @dle8 @findleyr