-
Notifications
You must be signed in to change notification settings - Fork 18k
strings: add ReplaceAll example #29199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
This PR (HEAD: b707457) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/153840 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
Message from Ian Lance Taylor: Patch Set 1: +bradfitz: I actually think that we should revert the change to strings/example_test.go in CL 137856. Then we can do this CL separately to add an example of ReplaceAll. Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
Message from Brad Fitzpatrick: Patch Set 1:
Whoops. Sent CL 153843 Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
This PR (HEAD: 4a13500) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/153840 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 4: Patch Set 3 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=f33c3927 Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/153840. |
This PR is being closed because golang.org/cl/153840 has been merged. |
Change-Id: I6b0d470bdedb92844943c8e5823e214d6a7471cf GitHub-Last-Rev: 4a13500 GitHub-Pull-Request: #29199 Reviewed-on: https://go-review.googlesource.com/c/153840 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
No description provided.