-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/tls: expose implemented cipher suites #30738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- adds public functions to retrieve available cipher suites (returning a copy of them to avoid external manipulation) - adds a "Name" field to the list of cipher suites to allow referencing them by name. This might come in handy building dynamic application configurations. - adds public functions to query a cipher by Id (returning a copy to avoid external manipulation) - adds public functions to query a cipher by name (returning a copy to avoid external manipulation) - exposes cipher suite flags, required to match ciphers against if desired
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Seems like this is the same as #30739. Closing this. |
Allows to dynamically retrieve a list of available cipher suites. This change allows a variety of applicatoins:
Ciphers are returned as copies, in order to avoid messing up internal stuff.
In contrast to the already discussed solutions, this one reduced the amount of necessary changes. Maintainability will be equal to before. This should not contain any breaking changes, as it only makes former private variables public, respectively, adds functions.
Fixes #30325 and #21167