Skip to content

testing/iotest: add ErrReader #34741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

testing/iotest: add ErrReader #34741

wants to merge 1 commit into from

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Oct 7, 2019 •
edited by odeke-em
Loading

Adds an io.Reader that always returns 0 and a non-nil error.

Fixes #38781

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 7, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 50b271e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 4 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:56
@gopherbot
Copy link
Contributor

This PR (HEAD: 9851fc0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@caarlos0
Copy link
Contributor Author

It's not clear if I need to do anything for this to be reviewed 🤔

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Code-Review-2

Thanks. New API like this should go through the proposal process. See https://golang.org/s/proposal.

Marking temporary -2 as this should not be submitted unless a proposal is written and accepted.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

See also https://golang.org/doc/faq#x_in_std.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@caarlos0 caarlos0 mentioned this pull request May 1, 2020
Closed
@caarlos0 caarlos0 changed the title testing/iotest: adds FailReader testing/iotest: adds ErrReader May 20, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 107dc44) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@caarlos0
Copy link
Contributor Author

Proposal was accepted #38781 🎊

carnott-snap
carnott-snap reviewed Aug 6, 2020
View reviewed changes
@gopherbot
Copy link
Contributor

This PR (HEAD: 4733ead) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 5:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8f71624) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@odeke-em odeke-em changed the title testing/iotest: adds ErrReader testing/iotest: add ErrReader Aug 16, 2020
@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 9: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ab496a14

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 9:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/ab496a14/freebsd-amd64-12_0_90abb1de.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 9: TryBot-Result-1

19 of 20 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/ab496a14/freebsd-amd64-12_0_90abb1de.log
Failed on misc-compile-darwin: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-darwin_6abd128b.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/ab496a14/linux-amd64_0d419c74.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/ab496a14/linux-386_56b2546c.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/ab496a14/windows-amd64-2016_2b03f103.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/ab496a14/openbsd-amd64-64_e5ac9156.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/ab496a14/js-wasm_77fb8c2c.log
Failed on misc-compile-solaris: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-solaris_8830eaa0.log
Failed on misc-compile-linuxarm: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-linuxarm_0fb4a64b.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/ab496a14/android-amd64-emu_7cb5cfed.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/ab496a14/windows-386-2008_9b8256d7.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/ab496a14/linux-amd64-race_1dfaeb88.log
Failed on misc-compile-plan9: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-plan9_c0fc2b3b.log
Failed on misc-compile-other: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-other_74803fae.log
Failed on misc-compile-freebsd: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-freebsd_227b0184.log
Failed on misc-compile-ppc: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-ppc_2f113828.log
Failed on misc-compile-mips: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-mips_c8944966.log
Failed on misc-compile-openbsd: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-openbsd_aff9f580.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/ab496a14/misc-compile-netbsd_1882cb4f.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 9:

Hey Carlos, did you run the changes locally and test? Seems like in the tests we already had the same type declared. Please remove it from log_test.go and keep its definition in the non test .go file and then adjust tests accordingly.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@caarlos0
testing/iotest: adds ErrReader
4e232b1 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: 4e232b1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/199501 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carlos Alexandro Becker:

Patch Set 9:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 10: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0d78f6bc

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 10: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199501.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/199501 has been merged.

@gopherbot gopherbot closed this Aug 17, 2020
gopherbot pushed a commit that referenced this pull request Aug 17, 2020
@caarlos0 @odeke-em
testing/iotest: add ErrReader
abfeec5 
Adds an io.Reader that always returns 0 and a non-nil error.

Fixes #38781

Change-Id: I56bd124de07bc8809e77c6cfaab33a1e32cfe2ee
GitHub-Last-Rev: 4e232b1
GitHub-Pull-Request: #34741
Reviewed-on: https://go-review.googlesource.com/c/go/+/199501
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carnott-snap carnott-snap carnott-snap left review comments

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing/iotest: add ErrReader
4 participants
@caarlos0 @gopherbot @carnott-snap @googlebot