-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime/cgo: let darwin pthread stacksize follow rlimit #53667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 7946bc0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415915 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 1: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Youlin Feng: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
This PR (HEAD: c7c3a14) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415915 to see it. Tip: You can toggle comments from me using the |
Message from Youlin Feng: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 3: Patch Set 2 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 3: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
This PR (HEAD: 8cf8877) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415915 to see it. Tip: You can toggle comments from me using the |
Message from hopehook: Patch Set 4: Run-TryBot+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Youlin Feng: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Zeke Lu: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
8cf8877
to
b29c745
Compare
This PR (HEAD: b29c745) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/415915 to see it. Tip: You can toggle comments from me using the |
Message from Youlin Feng: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from hopehook: Patch Set 5: Run-TryBot+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Cherry Mui: Patch Set 5: Run-TryBot+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415915. |
On Mac OS X, the default stack size for non-main threads created by cgo is fixed at 512KB and cannot be altered by setrlimit. This stack size is too small for some recursive scenarios. We can solve this problem by explicitly copying the stack size of the main thread when creating a new thread. Change-Id: I400d5b2e929a1ee261502914a991e208759f64a8 GitHub-Last-Rev: b29c745 GitHub-Pull-Request: #53667 Reviewed-on: https://go-review.googlesource.com/c/go/+/415915 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: hopehook <hopehook@golangcn.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
This PR is being closed because golang.org/cl/415915 has been merged. |
On Mac OS X, the default stack size for non-main threads created by cgo is
fixed at 512KB and cannot be altered by setrlimit. This stack size is too
small for some recursive scenarios. We can solve this problem by explicitly
copying the stack size of the main thread when creating a new thread.