-
Notifications
You must be signed in to change notification settings - Fork 18k
internal/fmtsort: makeChans pin pointer #62673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 1f70fa3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/528796. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from qiulaidongfeng: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Bryan Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
This PR (HEAD: cfe4ed2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/528796. Important tips:
|
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-10-03T19:38:26Z","revision":"f6774f92b98e0a89790100ac03aea74e937d6f23"} Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from qiulaidongfeng: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Bryan Mills: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
This PR (HEAD: 9f52aaa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/528796. Important tips:
|
Message from qiulaidongfeng: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
This PR (HEAD: 52284ba) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/528796. Important tips:
|
Message from qiulaidongfeng: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Keith Randall: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Bryan Mills: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Complete TODO. For golang#49431 Change-Id: Ifc79741ad44cd9631be49d4674db0ee52bbf6486
This PR (HEAD: 02cdea7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/528796. Important tips:
|
Message from qiulaidongfeng: Patch Set 5: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from qiulaidongfeng: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Go LUCI: Patch Set 5: CV cannot start a Run for Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from qiulaidongfeng: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Message from Bryan Mills: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/528796. |
Complete TODO. For #49431 Change-Id: I1399205e430ebd83182c3e0c4becf1fde32d433e GitHub-Last-Rev: 02cdea7 GitHub-Pull-Request: #62673 Reviewed-on: https://go-review.googlesource.com/c/go/+/528796 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Keith Randall <khr@golang.org> Commit-Queue: Keith Randall <khr@golang.org> Run-TryBot: qiulaidongfeng <2645477756@qq.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@google.com>
This PR is being closed because golang.org/cl/528796 has been merged. |
Complete TODO. For #49431 Change-Id: I1399205e430ebd83182c3e0c4becf1fde32d433e GitHub-Last-Rev: 02cdea740bccbe0993c53fecdd32608f08861e59 GitHub-Pull-Request: golang/go#62673 Reviewed-on: https://go-review.googlesource.com/c/go/+/528796 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Keith Randall <khr@golang.org> Commit-Queue: Keith Randall <khr@golang.org> Run-TryBot: qiulaidongfeng <2645477756@qq.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@google.com>
Complete TODO.
For #49431