This repository was archived by the owner on Jun 27, 2023. It is now read-only.
gomock.WithContext: controller with a context #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atals. testing.T.FailNow (and Fatal, ...) work only when called from the same goroutine as the test. This makes using gomock with e.g. RPC server mocks quite a challenge as the tests are likely to deadlock instead of failing properly. This adds a new constructor returning an additional context, which is cancelled on any fatal failure in mock.
Otherwise integration tests are unhappy.
|
This looks like a pretty decent solution to me. Thanks for getting a proposed fix out so quickly. |
|
I just happened to write this workaround for my code earlier the same day. :) @balshetzer, can you have a look? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gomock.WithContext: controller with a context which is cancelled on Fatals.
testing.T.FailNow (and Fatal, ...) work only when called from the same
goroutine as the test. This makes using gomock with e.g. RPC server
mocks quite a challenge as the tests are likely to deadlock instead of
failing properly.
This adds a new constructor returning an additional context, which is
cancelled on any fatal failure in mock.
This provides a reasonable workaround for #110 and similar issues.