Skip to content

Incorrect type in HookDelivery #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pierce-m opened this issue Dec 16, 2021 · 3 comments · Fixed by #2235
Closed

Incorrect type in HookDelivery #2234

pierce-m opened this issue Dec 16, 2021 · 3 comments · Fixed by #2235
Assignees
@pierce-m
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Comments

@pierce-m
Copy link
Contributor

Here the HookDelivery defines the InstallationID as type string, but from the documentation it seems like a number. When testing I receive the error string

json: cannot unmarshal number into Go struct field HookDelivery.installation_id of type string

Is this a possible bug?
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 16, 2021

Is this a possible bug?

Yes, would you like to create a PR?
Thank you, @pierce-m !

@pierce-m
Copy link
Contributor Author

Sure I'm happy to. Thanks!

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 16, 2021

Sure I'm happy to. Thanks!

Awesome... thanks again! It is yours. 😄

@pierce-m pierce-m mentioned this issue Dec 17, 2021
Merged
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Dec 18, 2021
gmlewis pushed a commit that referenced this issue Jan 3, 2022
@pierce-m
Change type of HookDelivery.InstallationID to int64 (#2235)
f334d81 
Fixes: #2234.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierce-m pierce-m

Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change type of HookDelivery.InstallationID to Int64. watchtowerai/go-github
2 participants
@pierce-m @gmlewis