Fix to GenerateChallenge #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisKarch
force-pushed
the
verification
branch
from
5d376c2 to
602cc77
Compare
|
Wait, this change was made in certificate transparency, not in crypto/x509 google/certificate-transparency-go#470 To use this in go-tspi, we need to use that package right? |
DenisKarch
force-pushed
the
verification
branch
2 times, most recently
from
a0f31c2 to
09510bf
Compare
crypto/x509 now enforces that rsa public keys must have NULL parameters. The old fix no longer solves the issue and instead will silently fail when parsing the key, ultimately causing a null pointer dereference at (pubkey := cert.PublicKey.(*rsa.PublicKey)). Currently working with crypto/x509 to add support for RSAES-OAEP keys golang/go#30416 certificate-transparency-go have accepted a temporary fix to /x509 google/certificate-transparency-go#470 so we will be building against them for the time being.
DenisKarch
force-pushed
the
verification
branch
from
09510bf to
f450a84
Compare
|
Yep, changed the import to build against google/certificate-transparency-go/x509 instead |
ericchiang
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto/x509 now enforces that rsa public keys must have NULL parameters.
The old hack no longer solves the issue and instead will silently fail when
parsing the key, ultimately causing a null pointer dereference at
(pubkey := cert.PublicKey.(*rsa.PublicKey)).
Currently working with crypto/x509 to add support for RSAES-OAEP keys
golang/go#30416