extensions: fix heap-buffer-overflow in hibaext_decode. #61
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
sshbuf_b64tod expects a NULL terminated string, but base64 encoded extensions may not be since they are extracted from an SSH buffer which manages size as metadata directly.
blunderer
force-pushed
the
fix-heap-buffer-overflow
branch
from
30405a0 to
59f76b3
Compare
|
macos build is broken due to missing u_int type definition that is now used in OpenSSH log.h This requires either porting the checks to HIBA configure.ac, or figuring out how to depend on OpenSSH config.h |
sshbuf_b64tod expects a NULL terminated string, but base64 encoded extensions may not be since they are extracted from an SSH buffer which manages size as metadata directly.