Spelling #1

jsoref · 2025-01-29T05:06:23Z

I understand that this repository may not be ready for contributions, but here's a round of changes...

There are a couple of commits with (?) that i'm less sure about.

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/pebble/actions/runs/13024954424#summary-36332391887

The action reports that the changes in this PR would make it happy:
https://github.com/jsoref/pebble/actions/runs/13024956111#summary-36332395838

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref

Some notes about my changes (many were drafted using GBoard, so I may have made some amusing mistakes of my own, I'm human too)

jsoref · 2025-01-29T12:28:28Z

platform/snowy/boot/src/drivers/display/ice40lp.c

@@ -171,7 +171,7 @@ void display_power_disable(void) {

 //!
 //! Write a single byte synchronously to the display. Use this
-//! sparingly, as it will tie up the micro duing the write.
+//! sparingly, as it will tie up the micro during the write.


This could be doing. All of my corrections are manual and this is an example where I picked one possible correction over another.

Thinking about it for a third time, it seems likely doing is the right word...

jsoref · 2025-01-29T12:29:49Z

platform/snowy/boot/src/drivers/pmic/max14690_pmic.c

@@ -327,7 +327,7 @@ static bool prv_is_alive(void) {
    return true;
  } else {
    PBL_LOG(LOG_LEVEL_DEBUG,
-            "Error: read max14690 whomai byte 0x%x, expecting 0x%x", val, 0x01);
+            "Error: read max14690 whoami byte 0x%x, expecting 0x%x", val, 0x01);


It's possible that whomai is some magical term of art, but I'm going it's just a typo.

jsoref · 2025-01-29T12:33:46Z

release-notes/ev2-4.txt

@@ -30,7 +30,7 @@ This archive contains the EV2-4 software for the Pebble E-Paper Watch.
    included in the directory. For more information, please refer to
    the 'Flash imaging tools' section.
  - docs/spi_flash_imaging.txt: A document describing the protocol
-    used to load load data onto Pebble's SPI flash via
+    used to load data onto Pebble's SPI flash via


Spell checking tools have complained about duplicate words for decades, and this is an example of such a correction. There are a couple of words that I left because they seemed to have value when repeated, but this just felt like an error.

jsoref · 2025-01-29T12:38:25Z

resources/normal/base/images/Pebble_50x50_Day_separator.svg

The tool checks the names of file paths.
The corresponding reference is changed in resources/normal/base/resource_map.json #1 (comment)

Pebble_50x50_Day_ -seperator +separator .svg

jsoref · 2025-01-29T12:41:01Z

src/fw/applib/applib_malloc.json

@@ -8,7 +8,7 @@
        "",
        "Types are defined below with the following parameters:                                  ",
        " name: The name of the type as it appears in our codebase. This type definition must    ",
-        "       be visibile in one of the headers in the headers list below.                     ",
+        "       be visible in one of the headers in the headers list below.                     ",


I generally try to fix up whitespace where it seems likely to matter, but I missed this case.

jsoref · 2025-01-29T15:25:42Z

tests/fw/graphics/test_graphics_fill_circle.template.c

@@ -605,7 +605,7 @@ void test_graphics_fill_circle_${BIT_DEPTH_NAME}__radial_precise(void){
  // Drawing
  setup_test_aa_sw(&ctx, fb, ORIGIN_RECT_NO_CLIP, ORIGIN_RECT_NO_CLIP, true, 1);
  graphics_fill_radial_precise_internal(&ctx, center, radius_inner, radius_outer, angle_start, angle_end);
-  cl_check(gbitmap_pbi_eq(&ctx.dest_bitmap, "fill_radial_origin_aa_precise_halfs_letter_c.${BIT_DEPTH_NAME}.pbi"));
+  cl_check(gbitmap_pbi_eq(&ctx.dest_bitmap, "fill_radial_origin_aa_precise_halves_letter_c.${BIT_DEPTH_NAME}.pbi"));


These files are renamed #1 (comment) #1 (comment)

jsoref · 2025-01-29T15:28:28Z

tests/fw/test_phone_formatting.c

@@ -108,7 +108,7 @@ void test_phone_formatting__overflowing_first_name(void) {
  char dest[NAME_LENGTH];
  memset(dest, GUARD_CHAR, NAME_LENGTH);

-  phone_format_caller_name("Pankajavalli Balamarugan", dest, buffer_length);
+  phone_format_caller_name("Pankajavalli Balamurugan", dest, buffer_length);


Notable... I'm pretty sure this was a dev.

jsoref · 2025-01-29T15:30:38Z

tests/test_images/fill_radial_origin_aa_precise_halves_letter_c.1bit.png

Reference is renamed #1 (comment)

jsoref · 2025-01-29T15:30:54Z

tests/test_images/fill_radial_origin_aa_precise_halves_letter_c.8bit.png

Reference is renamed #1 (comment)

jsoref · 2025-01-29T15:32:04Z

tools/activity/fft.py

@@ -377,8 +377,8 @@ def print_graph(x):
        print "\n############ INPUT ######################"
        print_graph(input)

-        print "\n############ GAUSIAN OF INPUT ############"
-        # input = apply_gausian(input, 0.1)
+        print "\n############ GAUSSIAN OF INPUT ############"


This does change the width of a thing, but this line was already wider than the INPUT line, so I didn't think it was worth removing trailing #s.

jsoref added 30 commits January 29, 2025 00:03

spelling: intentionally

ef3b422

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: internal

c0f95d0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: invalid

1414ea0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: invert

57fd176

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: issues

2437efd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: iterating

d78f6df

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: iteration

a35061e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: its

4806c06

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: javascript

c01e9cf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: kernel

cb0ad69

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: large

f26b13d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: latest

a503372

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: layer (?)

087fa58

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: leaving

7ee4164

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: length

2ca6621

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: lifecycle

9a74f51

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: light

efb437b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: limit

4e17c71

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: load

df09a16

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: lowest

dff7972

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: macos

f8142aa

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: makes

0527df2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: malformed

04822e0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: many, many,

14c0197

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: measurement

3103346

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: memory

1e36e93

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: messages

4484069

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: metadata

2d73a5d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: milliseconds

8db950e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: minimized

13f4c19

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 29 commits January 29, 2025 00:03

spelling: unless

82ee3a2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unnamed

523e6cf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unnecessarily

c32466e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsubscribe

445eb14

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsubscribed

0f74b40

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsuccessful

03c66ad

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unused

58d50a7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: use

a679c3d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

d37fe94

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: variable

c1e8ef3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: version

0098e27

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: vertical

159e6cc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: vertically

39c1e7b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: violations

36c9aac

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: visible

7499ab1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: wakeup

3bde9c1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: watchbands

7885833

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: when

8ee2a95

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whenever

b778cd6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: where

09c53eb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whether

fed3c7b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whoami

be5dc94

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: window

4f5fbed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

7049285

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: within

af088d0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workaround

a33fc19

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workarounds

bb79879

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: written

718ea62

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: yesterday

ecfd50f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Jan 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #1

Spelling #1

jsoref commented Jan 29, 2025 •

edited

Loading

jsoref left a comment

jsoref Jan 29, 2025

jsoref Jan 29, 2025

jsoref Jan 29, 2025

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025

Spelling #1

Are you sure you want to change the base?

Spelling #1

Conversation

jsoref commented Jan 29, 2025 • edited Loading

jsoref left a comment

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

jsoref Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

jsoref Jan 29, 2025

Choose a reason for hiding this comment

jsoref commented Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025 •

edited

Loading

jsoref Jan 29, 2025 •

edited

Loading