Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing python version 3.7 on test matrix #13

Merged
merged 2 commits into from
May 13, 2023

Conversation

robsonpeixoto
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented May 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@robsonpeixoto robsonpeixoto changed the title Add missing python version 3.7 on test matrix and fix tests Add missing python version 3.7 on test matrix May 12, 2023
@yilei
Copy link

yilei commented May 12, 2023

Thanks for the PR!

Do you have the need to run it on 3.7? Python 3.7 EOL is only 6 weeks away (https://endoflife.date/python), so we'll drop it soon anyway afterwards.

@robsonpeixoto
Copy link
Author

Unfortunately I using python 3.7 in some projects :/

@yilei is necessary remove this line: https://github.com/google/pyink/blob/pyink/pyproject.toml#L29

@yilei yilei self-requested a review May 13, 2023 18:18
@yilei yilei merged commit be91ecd into google:pyink May 13, 2023
@robsonpeixoto robsonpeixoto deleted the fix/py-37 branch May 13, 2023 18:34
copybara-service bot pushed a commit that referenced this pull request May 15, 2023
…the last commit.

PiperOrigin-RevId: 532214823
copybara-service bot pushed a commit that referenced this pull request May 15, 2023
…the last commit.

PiperOrigin-RevId: 532214823
copybara-service bot pushed a commit that referenced this pull request May 15, 2023
…the last commit.

PiperOrigin-RevId: 532214823
copybara-service bot pushed a commit that referenced this pull request May 15, 2023
…the last commit.

PiperOrigin-RevId: 532240873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants