Skip to content

Ensure that the AuthCode gets set correctly. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Ensure that the AuthCode gets set correctly. #7

merged 1 commit into from
Nov 13, 2017

Conversation

lukezbihlyj
Copy link
Contributor

This fixes a bug where the AuthCode will always be null even when RequestAuthCode is enabled in the global configuration. Tested in an app built with Unity 2017 on a real iOS device.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@lukezbihlyj
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@claywilkinson claywilkinson merged commit 6c13b2c into googlesamples:master Nov 13, 2017
@claywilkinson
Copy link
Contributor

Great Catch! thanks!

claywilkinson added a commit that referenced this pull request Jan 24, 2018
Ensure that the AuthCode gets set correctly.

Change-Id: Icc29bf695ae993169b70c73ab027a3712fd96eb9
n0ise9914 pushed a commit to n0ise9914/google-signin-unity that referenced this pull request Mar 31, 2020
Ensure that the AuthCode gets set correctly.
n0ise9914 pushed a commit to n0ise9914/google-signin-unity that referenced this pull request Mar 31, 2020
Ensure that the AuthCode gets set correctly.

Change-Id: Icc29bf695ae993169b70c73ab027a3712fd96eb9
n0ise9914 pushed a commit to n0ise9914/google-signin-unity that referenced this pull request Mar 31, 2020
Ensure that the AuthCode gets set correctly.
n0ise9914 pushed a commit to n0ise9914/google-signin-unity that referenced this pull request Mar 31, 2020
Ensure that the AuthCode gets set correctly.

Change-Id: Icc29bf695ae993169b70c73ab027a3712fd96eb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants