Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.

Single Schema + Swift 3.1 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gperdomor
Copy link
Owner

  • Convert project to single schema for all platforms
  • Update deps

@gperdomor-github-bot
Copy link

gperdomor-github-bot commented Apr 3, 2017

1 Error
🚫 Added or removed library files require the Carthage Xcode project to be updated.
1 Warning
⚠️ Big PR

SwiftLint found issues

Warnings

File Line Reason
GitHubAPI.swift 14 Force unwrapping should be avoided.
GitHubAPI.swift 26 Force unwrapping should be avoided.
GitHubAPI.swift 52 Force unwrapping should be avoided.
GitHubAPI.swift 54 Force unwrapping should be avoided.
GitHubAPI.swift 56 Force unwrapping should be avoided.
GitHubAPI.swift 58 Force unwrapping should be avoided.
MoyaViewController.swift 31 Force unwrapping should be avoided.
MoyaViewController.swift 73 Force unwrapping should be avoided.
MoyaViewController.swift 83 if,for,while,do statements shouldn't wrap their conditionals in parentheses.
GithubEndpoint.swift 15 Force unwrapping should be avoided.
GithubEndpoint.swift 25 Force unwrapping should be avoided.
GithubEndpoint.swift 57 Force unwrapping should be avoided.
GithubEndpoint.swift 70 Force unwrapping should be avoided.
MoyaModelMapperSpec.swift 15 Function body should span 50 lines or less excluding comments and whitespace: currently spans 120 lines
ReactiveMoyaModelMapperSpec.swift 18 Function body should span 50 lines or less excluding comments and whitespace: currently spans 214 lines
RxMoyaModelMapperSpec.swift 90 Force unwrapping should be avoided.
RxMoyaModelMapperSpec.swift 105 Force unwrapping should be avoided.
RxMoyaModelMapperSpec.swift 202 Force unwrapping should be avoided.
RxMoyaModelMapperSpec.swift 218 Force unwrapping should be avoided.
RxMoyaModelMapperSpec.swift 19 Function body should span 50 lines or less excluding comments and whitespace: currently spans 170 lines

Errors

File Line Reason
SignalProducer+ModelMapper.swift 73 Force casts should be avoided.
ReactiveMoyaModelMapperSpec.swift 18 Function should have complexity 10 or less: currently complexity equals 34

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 3, 2017

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          80     80           
=====================================
  Hits           80     80
Impacted Files Coverage Δ
...veMoyaModelMapper/SignalProducer+ModelMapper.swift 100% <ø> (ø) ⬆️
...ces/RxMoyaModelMapper/Observable+ModelMapper.swift 100% <ø> (ø) ⬆️
Sources/MoyaModelMapper/Response+ModelMapper.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2ea53...f580692. Read the comment docs.

@gperdomor gperdomor force-pushed the feature/single-target branch from 9614987 to c69305c Compare April 3, 2017 02:18
Update deps for Swift 3.1 compatibility
@gperdomor gperdomor force-pushed the feature/single-target branch from c69305c to f580692 Compare April 3, 2017 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants