browser: race fixes #4523
Merged
browser: race fixes #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
force-pushed
the
fixBrowserRacesInMapping2
branch
from
8fb90fc to
86c387b
Compare
mstoykov
requested review from
oleiade and
olegbespalov
and removed request for
a team
olegbespalov
previously approved these changes
Feb 10, 2025
joanlopez
previously approved these changes
Feb 10, 2025
mstoykov
dismissed stale reviews from joanlopez and olegbespalov
The base branch was changed.
mstoykov
force-pushed
the
fixBrowserRacesInMapping2
branch
from
86c387b to
1d973b1
Compare
olegbespalov
previously approved these changes
Feb 10, 2025
Specifically for: - dbclick - dispatchEvent - fill - focus - getAttribute - hover - innerHTML - innerText - inputValue
mstoykov
force-pushed
the
fixBrowserRacesInMapping2
branch
from
1d973b1 to
e10baf2
Compare
joanlopez
approved these changes
Feb 10, 2025
olegbespalov
approved these changes
Feb 10, 2025
codebien
reviewed
Feb 10, 2025
| @@ -45,18 +45,23 @@ func mapFrame(vu moduleVU, f *common.Frame) mapping { | |||
| return f.Content() //nolint:wrapcheck | |||
| }) | |||
| }, | |||
| "dblclick": func(selector string, opts sobek.Value) *sobek.Promise { | |||
| "dblclick": func(selector string, opts sobek.Value) (*sobek.Promise, error) { | |||
| popts := common.NewFrameDblClickOptions(f.Timeout()) | |||
There was a problem hiding this comment.
Just as a comment, in this scope, what is the meaning of pops? Parsed options? It sounds a bit ambiguous to me. We should change to something else where it is or Frame Options or the specific DB Options, which converts to fopts or dbopts. I prefer the latter.
Of course, all of this, not in this pull request.
There was a problem hiding this comment.
It is parsed options and was what was used in the code that we pull out so it isn't in a separate goroutine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixing more page and frame (where they intersect) mappings
Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)