Add true color detection for k6 banner #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
mstoykov and
codebien
and removed request for
a team
This will cover most cases, but we can still improve it later. It feels safer to fallback to a 256-color scheme rather than enabling TrueColor from the get go.
inancgumus
force-pushed
the
add/true-color-detection
branch
from
cc3b501 to
f9a4877
Compare
codebien
approved these changes
Feb 14, 2025
mstoykov
approved these changes
Feb 14, 2025
inancgumus
added
documentation-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Only color the k6 logo with
RGB(0xFF, 0x67, 0x1d)if the terminal supports TrueColor. Otherwise, it picks k6 v0.54.0's yellow color. This change should cover most cases, but we can still improve it later. It feels safer to fall back to a 256-color scheme rather than using TrueColor from the get-go.Why?
#4542
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)