Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser: Fix ElemenHandle.SelectOption sobek #4574

Merged
merged 1 commit into from
Feb 24, 2025
Merged

browser: Fix ElemenHandle.SelectOption sobek #4574

merged 1 commit into from
Feb 24, 2025
+8 −9

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 20, 2025 •
edited
Loading

What?

Fixes one more Sobek value usage for ElementHandle: SelectOption.

Why?

Fixing potential race conditions.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes (locally tested).
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the k6-documentation: grafana/k6-docs#PR-NUMBER
  • I have updated the TypeScript definitions: grafana/k6-DefinitelyTyped#PR-NUMBER
  • I have updated the release notes: d8881c9

Related PR(s)/Issue(s)

@inancgumus inancgumus added this to the v1.0.0-rc1 milestone Feb 20, 2025
@inancgumus inancgumus self-assigned this Feb 20, 2025
@inancgumus inancgumus changed the title browser: Fix ElemenHandle.SelectOption sobek browser: Fix ElemenHandle.SelectOption sobek Feb 20, 2025
@inancgumus inancgumus marked this pull request as ready for review February 20, 2025 17:11
@inancgumus inancgumus requested a review from a team as a code owner February 20, 2025 17:11
@inancgumus inancgumus requested review from mstoykov and joanlopez and removed request for a team February 20, 2025 17:11
@inancgumus inancgumus merged commit 07d1906 into master Feb 24, 2025
28 checks passed
@inancgumus inancgumus deleted the fix/sobek-values-for-elementhandle-select-option branch February 24, 2025 14:40
@inancgumus inancgumus mentioned this pull request Feb 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees

@inancgumus inancgumus

Labels
area: browser bug
Projects
None yet
Milestone
v1.0.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @mstoykov @joanlopez