Upgrade to golangci-lint v1.53.3 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running locally fails: make lint
docker run --rm -v /home/pablo/go/src/github.com/grafana/xk6-disruptor:/disruptor -w /disruptor golangci/golangci-lint:v1.53.3 golangci-lint run
level=warning msg="[runner] Can't run linter goanalysis_metalinter: musttag: running `go list all`: exit status 1"
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: musttag: running `go list all`: exit status 1\n\n"
make: *** [Makefile:45: lint] Error 3 |
|
@pablochacin Interesting, I thought this issue was on my end due to my source tree not being readable by others. The root cause is that git refuses to run on directories the current user doesn't own. This did not happen in the past, so my best guess is that the updated container image also updates the git binary. Outside of the container, this issue does not occur. I'll check to see if there's a workaround. |
|
@pablochacin I've added a workaround in bdf85cd. The issue in play is a bit obscure, I've added an extended explanation in the commit message. LMK if it seems clear, or if you have concerns with it. |
nadiamoe
force-pushed
the
golangci-1-53-3
branch
from
377f571 to
fbc9d33
Compare
This works around the issue of `go list all` failing when invoking git operations, as git refuses to run in a directory owned by someone else by default: ``` $> docker run --rm -ti -v `pwd`:/disruptor -w /disruptor golangci/golangci-lint:v1.53.3 go list all go: downloading github.com/go-openapi/jsonpointer v0.19.6 error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. ``` ``` $> docker run --rm -ti -v `pwd`:/disruptor -w /disruptor golangci/golangci-lint:v1.53.3 git status fatal: detected dubious ownership in repository at '/disruptor' To add an exception for this directory, call: git config --global --add safe.directory /disruptor ```
nadiamoe
force-pushed
the
golangci-1-53-3
branch
from
fbc9d33 to
bdf85cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #232
Checklist:
make lint) and all checks pass.make test) and all tests pass.make e2e-xxxforagent,disruptors,kubernetesorclusterrelated changes)