Add tool for e2e test cluster setup and cleanup #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
e2e-test-setup-cleanup
branch
3 times, most recently
from
f652a1f to
59edf00
Compare
nadiamoe
approved these changes
Aug 23, 2023
cmd/e2e-cluster/commands/setup.go
Outdated
Comment on lines
40
to
41
| cmd.Flags().StringArrayVarP(&images, "image", "i", cluster.DefaultE2eClusterConfig().Images, | ||
| "additional image to pre-load in the cluster") |
There was a problem hiding this comment.
Does cobra handle array args as comma-separated list, or as specify the flag multiple times?
I never remember which is which, so I would suggest to specify this in the help message.
There was a problem hiding this comment.
Good point. It supports both. I will add this to the comment.
|
|
||
| > Note: if you are testing changes in the agent, be sure you generate the image and [upload it to the cluster](#building-the-xk6-disruptor-agent-image) using kind | ||
|
|
||
| When you don't longer needs the cluster, you can delete it using kind: | ||
| When you don't longer needs the cluster, you can delete it using the [e2e-cluster tool](#e2e-cluster-tool) or `kind`: |
There was a problem hiding this comment.
Double space
Suggested change
| When you don't longer needs the cluster, you can delete it using the [e2e-cluster tool](#e2e-cluster-tool) or `kind`: | |
| When you don't longer needs the cluster, you can delete it using the [e2e-cluster tool](#e2e-cluster-tool) or `kind`: |
| This behavior is controlled by passing the `WithKeepOnFail` option when creating the namespace or by setting `E2E_KEEPONFAIL=true` in the environment when running an e2e test. |
There was a problem hiding this comment.
Other env vars are set to 0 or 1, but this one we set it to true. IIRC both are okay as we use strconv.ParseBool which accepts both, but I think it would be good to stick to one or the other in the examples.
There was a problem hiding this comment.
Good catch. It should also be 1.
pablochacin
force-pushed
the
e2e-test-setup-cleanup
branch
from
97f4e36 to
e32ca86
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
e2e-test-setup-cleanup
branch
from
e32ca86 to
1af2329
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #311
Checklist:
make lint) and all checks pass.make test) and all tests pass.make e2e-xxxforagent,disruptors,kubernetesorclusterrelated changes)