Update dependency env_logger from 0.6 to 0.10.2 #521
Conversation
|
Ci is failing with I don't have the bandwidth to check right now, but it should be straightforward to fix. |
…inimum rust version to 1.71. This conflicts with graphql-client's minimum of 1.64
jimmystewpot
changed the title
|
@tomhoule, thanks for looking at this pr so quickly. I have not been checking the MSRV information on packages, so this one slipped through the net. The problem with CI is caused by the minimum version for graphql-client 1.64 vs. a style (via env_logger), which is 1.71. I reverted the env_logger to 0.10.2, which is the last version that supports 1.64. I started working on this update to make cross-platform terminal colours less buggy. I've now reverted the code back to pre-change and left only the dependency update in place (to 0.10.2) Should the minimum version of rust supported by graphql-client by bumped to something more recent? (This is a supplementary question) In Summary, the version has gone from 0.6 to 0.10.2 for env_logger; I've updated the subject/title of the PR to reflect the difference. I've also removed the tests. |
Absolutely. I'm going to cut a release very soon, and we can make a few breaking changes, including bumping the MSRV right after that. |
The
env_loggerAPI has changed in recent revisions, bringing up the dependency to a more recent version to make the codebase easier to maintain in the long term.A test that defaults to ignored has been left to test any future API changes if required; I have left it there just for simple iterative testing, although it could be removed as it's trivial. Otherwise, this shouldn't break anything.