-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Replace ExecuteSelectionSet
with ExecuteCollectedFields
#1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjie
wants to merge
17
commits into
main
Choose a base branch
from
benjie/incremental-common
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b76671b
Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSu…
benjie c9837a4
Change ExecuteSelectionSet to ExecuteGroupedFieldSet
benjie a52310e
Correct reference to MergeSelectionSets
benjie 60a9c35
move Field Collection section earlier (#1111)
yaacovCR a1de2dd
Merge branch 'main' into benjie/incremental-common
benjie e8f80c8
Merge branch 'main' into benjie/incremental-common
benjie 213fd2a
Define 'grouped field set'
benjie 383cf8e
that -> which
benjie 48a789b
More similar to prior wording
benjie 0b9eed7
Remove reason from definition
benjie 0728c4a
subGroupedFieldSet -> fieldGroupedFieldSet
benjie 140c3da
Add note for clarity
benjie 65df539
Merge branch 'main' into benjie/incremental-common
benjie d68df95
move field collections into one section, section reworking, minor wor…
leebyron 180a51c
Apply suggestions from code review
benjie 3c6dfb3
Rename 'ExecuteGroupedFieldSet' to 'ExecuteCollectedFields'
benjie 5459f16
Merge branch 'main' into benjie/incremental-common
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR but a more precise wording would be to use
selectionSet
here as fragments are also valid, not only fields.